[8DOT3] Improve test coverage, removing unused exception handling

os.path.splitext always returns a tuple with two elements, so IndexError cannot be raised.
nathanhi · Jun 11, 2023 · c8b4f30 · c8b4f30
1 parent ae8af20
commit c8b4f30
Showing 1 changed file with 11 additions and 17 deletions.
diff --git a/pyfatfs/EightDotThree.py b/pyfatfs/EightDotThree.py
@@ -214,23 +214,17 @@ def map_chars(name: bytes) -> bytes:
             return _name
 
         dir_name = dir_name.upper()
-        try:
-            # Shorten to 8 chars; strip invalid characters
-            basename = os.path.splitext(dir_name)[0][0:8].strip()
-            basename = basename.encode(parent_dir_entry._encoding,
-                                       errors="replace")
-            basename = map_chars(basename).decode(parent_dir_entry._encoding)
-        except IndexError:
-            basename = ""
-
-        try:
-            # Shorten to 3 chars; strip invalid characters
-            extname = os.path.splitext(dir_name)[1][1:4].strip()
-            extname = extname.encode(parent_dir_entry._encoding,
-                                     errors="replace")
-            extname = map_chars(extname).decode(parent_dir_entry._encoding)
-        except IndexError:
-            extname = ""
+        # Shorten to 8 chars; strip invalid characters
+        basename = os.path.splitext(dir_name)[0][0:8].strip()
+        basename = basename.encode(parent_dir_entry._encoding,
+                                   errors="replace")
+        basename = map_chars(basename).decode(parent_dir_entry._encoding)
+
+        # Shorten to 3 chars; strip invalid characters
+        extname = os.path.splitext(dir_name)[1][1:4].strip()
+        extname = extname.encode(parent_dir_entry._encoding,
+                                 errors="replace")
+        extname = map_chars(extname).decode(parent_dir_entry._encoding)
 
         if len(extname) == 0:
             extsep = ""