Feature request - expose prometheus metrics #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… using metrics) Initialise metric counter for each label in use Move frame counter metric initialisation call next to label metic counter initialisation
Fix no-log argument for new deepsort module
Increment metrics for newly seen objects
Move http server (for metric) start inside main() so it can reference arguments
… for all possible model labels, otherwise label counter metrics are added as they are seen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be nice to make the counters for how many objects have been counted available to prometheus/grafana. It defaults to making these available on port 8000 as metrics like:
umt_object_counter_total{type="vehicle"} 14.0
along with frame counters such as:
umt_frame_counter_total{result="no_detection"} 1361.0
umt_frame_counter_total{result="detection"} 304.0
umt_frame_counter_total{result="error"} 0.0
As part of this I've also added a command line option to disable logging to object_paths.csv (in my case, so I didn't run out of disk space).
FYI, this fork also includes the patch to fix the deepsort camera bug mentioned in #9