WIP: support multiple addresses for network interfaces #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the idea is to use the kind_of attribute of a property to differentiate between properties that need array values to be joined by " " and propertties that need to be written multiple times in the unit file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to use the
kind_ofattribute of a property to differentiate betweenproperties that need array values to be joined by " " and properties that need
to be written multiple times in the unit file
This patch is meant to be backwards compatible for other properties.
However, a better approach would be to do it the other way around and to introduce a class JoinedArray and then to do the " " join in options_value only for those properties that include the JoinedArray in their
kind_ofattributeIf you like the idea, let me know and I will do it that way.