Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust activity logic #127

Closed
wants to merge 4 commits into from
Closed

Conversation

@TTNguyenDev TTNguyenDev requested a review from a team as a code owner April 6, 2024 13:07
@TTNguyenDev TTNguyenDev requested a review from aahna-ashina April 6, 2024 13:07
@aahna-ashina
Copy link
Member

aahna-ashina commented Apr 6, 2024

Can you also run the script to see how these changes affect the generated CSV files?

@TTNguyenDev
Copy link
Contributor Author

Hi @aahna-ashina, please confirm: with this update, a citizen is considered to be active if they have contributed at least 1 hour in 2 weeks, and it has to happen within a month, correct? So, let's say they can contribute 1 hour in week 1 and 1 hour in week 4?

@TTNguyenDev
Copy link
Contributor Author

Do we accept 0.5 hour in week 1 and 0.5 hour in week 2?

@TTNguyenDev
Copy link
Contributor Author

image
Please check this file after changing the logic

Copy link
Member

@aahna-ashina aahna-ashina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least 2 hour per week

This is not correct. We are still using the "1 hour per week" number.

@TTNguyenDev
Copy link
Contributor Author

TTNguyenDev commented Apr 8, 2024

So the condition should be
week4 > 1 || week3 > 1
right?
Currently, I'm using week4 + week3 > 1 @aahna-ashina please confirm

@aahna-ashina
Copy link
Member

aahna-ashina commented Apr 8, 2024

So the condition should be

week4 > 1 || week3 > 1

right?

Currently, I'm using week4 + week3 > 1 @aahna-ashina please confirm

@TTNguyenDev No, not right, because the citizen needs to have activity in 4 weeks in sequence.

This can happen in two ways:

  • 5 weeks ago, and
  • 4 weeks ago, and
  • 3 weeks ago, and
  • 2 weeks ago

or

  • 4 weeks ago, and
  • 3 weeks ago, and
  • 2 weeks ago, and
  • last week

@aahna-ashina
Copy link
Member

Fixed in #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants