[FCL-626] Reinstate updating a document URI on NCN update #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonj04
force-pushed
the
FCL-626-when-a-judgment-is-saved-in-eui-and-the-ncn-changes-it-should-still-overwrite-the-uri
branch
10 times, most recently
from
4d314f4 to
eaa9cb5
Compare
dragon-dxw
reviewed
Jan 29, 2025
dragon-dxw
reviewed
Jan 29, 2025
dragon-dxw
reviewed
Jan 29, 2025
dragon-dxw
reviewed
Jan 29, 2025
dragon-dxw
reviewed
Jan 29, 2025
dragon-dxw
reviewed
Jan 29, 2025
dragon-dxw
approved these changes
Jan 29, 2025
|
Code Climate seems to be blocking merge. I don't seem to be able to meaningfully interact with CodeClimate to see what's wrong. |
jacksonj04
force-pushed
the
FCL-626-when-a-judgment-is-saved-in-eui-and-the-ncn-changes-it-should-still-overwrite-the-uri
branch
from
eaa9cb5 to
e32c8b4
Compare
As part of this, we refactor the old NCN updating behaviour to be more isolated, robust and testable.
jacksonj04
force-pushed
the
FCL-626-when-a-judgment-is-saved-in-eui-and-the-ncn-changes-it-should-still-overwrite-the-uri
branch
3 times, most recently
from
0f57fab to
1747950
Compare
The EUI doesn't need its own implementations of these; delete and use the ones from the API Client instead. As part of this we get the better type checking from the API Client, so make necessary adjustments.
jacksonj04
force-pushed
the
FCL-626-when-a-judgment-is-saved-in-eui-and-the-ncn-changes-it-should-still-overwrite-the-uri
branch
from
1747950 to
32811e0
Compare
jacksonj04
deleted the
FCL-626-when-a-judgment-is-saved-in-eui-and-the-ncn-changes-it-should-still-overwrite-the-uri
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't yet implemented the ingester change to provide UUID-based document URIs, but editors are still receiving documents at
/failureURIs. Since the new code won't change these (by design), we need to temporarily reinstate the functions which update the URI when the NCN changes.As part of this we refactor out the logic in
EditJudgmentView.postwhich processes the actual change into a newupdate_ncn_of_documentmethod.