[FCL-569] Press summaries should be assigned press summary related NCN identifiers, not real NCNs #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
force-pushed
the
press-summaries-get-different-identifiers
branch
5 times, most recently
from
5ada448 to
1cc9e41
Compare
|
For some reason, locally, when trying to smoketest this, it doesn't extract the Neutral Citation number for Press Summaries. Which works fine if I try loading it up directly in the API client. Still, probably better than collisions. |
jacksonj04
changed the title
jacksonj04
requested changes
Jan 20, 2025
dragon-dxw
force-pushed
the
press-summaries-get-different-identifiers
branch
from
2f6819b to
0d09002
Compare
dragon-dxw
force-pushed
the
press-summaries-get-different-identifiers
branch
from
0d09002 to
3274ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs actually testing locally, but the tests pass.
https://my.slack.com/archives/C02TP2L2Z0F/p1736524476515919