[FCL-644] Improve typing and code robustness #260
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonj04
force-pushed
the
FCL-644-ingester-should-assign-a-uuid-based-uri-to-documents-with-no-ncn
branch
from
9012489 to
609679f
Compare
jacksonj04
changed the title
jacksonj04
force-pushed
the
FCL-644-ingester-should-assign-a-uuid-based-uri-to-documents-with-no-ncn
branch
9 times, most recently
from
6a6f534 to
91be496
Compare
dragon-dxw
reviewed
Feb 12, 2025
jacksonj04
force-pushed
the
FCL-644-ingester-should-assign-a-uuid-based-uri-to-documents-with-no-ncn
branch
from
91be496 to
323208c
Compare
dragon-dxw
reviewed
Feb 12, 2025
| @@ -336,23 +337,38 @@ def test_store_metadata(self, api_client, v2_ingest): | |||
| def test_store_file_success(self, mock_print): | |||
| session = boto3.Session | |||
There was a problem hiding this comment.
These could probably use moto but maybe not this PR.
| xml_file = extract_xml_file(tar, xml_file_name) | ||
| if xml_file: | ||
| contents = xml_file.read() | ||
| contents = xml_file.read().decode("utf-8") # We assume here that our XML is in UTF-8 |
There was a problem hiding this comment.
Whilst true in practice, I don't think this should be something we have to assume. I think lxml will raise an exception if it receives str XML with a document type preamble, since it's now not accurately describing the document.
| s3_client.copy(source, public_bucket, key, extra_args) | ||
|
|
||
|
|
||
| def parse_xml(xml) -> ET.Element: | ||
| def parse_xml(xml: str) -> ET.Element: |
There was a problem hiding this comment.
bytes? (see other comment )
jacksonj04
force-pushed
the
FCL-644-ingester-should-assign-a-uuid-based-uri-to-documents-with-no-ncn
branch
from
323208c to
8f4bd35
Compare
dragon-dxw
reviewed
Feb 13, 2025
This method isn't accessible from any code path.
jacksonj04
force-pushed
the
FCL-644-ingester-should-assign-a-uuid-based-uri-to-documents-with-no-ncn
branch
from
8f4bd35 to
a7fb4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we're more confident making changes in future, add some missing type annotations to the codebase.