Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more footnote classes and hidden footnote text #60

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

jurisdatum
Copy link
Collaborator

@jurisdatum jurisdatum commented Apr 16, 2024

These are the changes requested by Tim in FCL-41. Footnote markup will now look like this:

<p>
  Some body text.
  <a id="fnref1" href="#fn1" class="judgment-body__footnote-reference">
    <span class="judgment__hidden"> (Footnote: </span>
    <sup>1</sup>
    <span class="judgment__hidden">)</span>
  </a>
</p>

and

<footer class="judgment-footer">
  <hr>
  <div>
    <p id="fn1" class="judgment-footer__footnote">
      <a href="#fnref1" class="judgment-footer__footnote-backlink">
        <span class="judgment__hidden"> (Footnote reference from: </span>
        <sup>1</sup>
        <span class="judgment__hidden">)</span>
      </a>
      Some footnote text.
    </p>
  </div>
  ...
</footer>

Copy link
Contributor

@timcowlishaw timcowlishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @jurisdatum!

I'm off tomorrow, but @dragon-dxw is there any chance we could push this up to staging at some point on thursday? I can then ship the frontend changes and unblock the release.

@dragon-dxw dragon-dxw merged commit e51e9a6 into main Apr 17, 2024
4 checks passed
@dragon-dxw
Copy link
Collaborator

Deployed to staging.

@timcowlishaw
Copy link
Contributor

aha ace, thank you @dragon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants