Make older judgments visible; separate minimum sensible and allowed dates #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragon-dxw
changed the title
from dates
dragon-dxw
changed the title
from dates
dragon-dxw
force-pushed
the
bug/old-judgments-invisible
branch
from
ad6a992 to
742155e
Compare
jacksonj04
reviewed
Jan 31, 2025
|
|
||
| if not iso_date: | ||
| return False, None | ||
| from_date = date.fromisoformat(iso_date) | ||
| # If the date is 1085, then that's the default, the user hasn't typed in | ||
| # a non-sensical answer, don't warn about it. | ||
| if from_date.year == settings.MINIMUM_ALLOWED_YEAR: |
There was a problem hiding this comment.
This makes me a bit twitchy because if a user does type "1085" then we should still warn them, but solving it is a bit of a faff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-2001 judgments were not showing up properly on staging -- we probably could have changed the default oldest date, but realistically separating out the minimum valid (some time after 1000) and sensible (oldest judgment; defaulting to 2003-ish) more carefully was needed.
Jira card / Rollbar error (etc)
https://national-archives.atlassian.net/browse/FCL-635