Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCL-631 | add front-end ADRS #185

Merged
merged 2 commits into from
Feb 13, 2025
Merged

FCL-631 | add front-end ADRS #185

merged 2 commits into from
Feb 13, 2025

Conversation

jlhdxw
Copy link
Collaborator

@jlhdxw jlhdxw commented Feb 12, 2025

Adds 1 proposed ADR:

  • 46. Link Classes for Analytics

And adds the following ADRs that are already accepted:

  • 22. TNA Front-End Colour Overrides
  • 23. StyleLint Configuration
  • 24. Usage of GOV.UK Front-End
  • 25. Usage of Home Office Front-End
  • 26. Playwright for End-to-End Testing
  • 27. Automated Accessibility Checking
  • 28. Using SASS for All CSS
  • 29. CSS Spacing Variable Convention
  • 30. CSS Typography Variable Convention
  • 31. Jest for JavaScript Unit Tests
  • 32. Standard Content Layout
  • 33. GOV.UK Front-End CSS Overrides
  • 34. GOV.UK Front-End CSS Imports
  • 35. Bundled JavaScript vs. Page-Specific JavaScript
  • 36. Style Guide Page
  • 37. Webpack for JavaScript and CSS Compilation
  • 39. Automatic Linting Before Code Push
  • 40. Atomic CSS Classes
  • 41. Cypress for End-to-End Tests
  • 42. jQuery
  • 43. Judgment Paragraph Anchors
  • 44. Judgment Tables
  • 45. Buttons


- All committed code will be linted, ensuring consistency across the codebase.
- Developers accustomed to frequent small commits may need to adjust to a slower workflow due to linting execution.
- Developers must set up pre-commit hooks in each repository to ensure enforcement.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth documenting that we're using pre-commit (the application, rather than the hooks directly), possibly linking to https://pre-commit.com/#usage

Copy link
Collaborator

@dragon-dxw dragon-dxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, but think it's worth other people reviewing too.

Copy link

@Terry-Price Terry-Price left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Floppy For #27 - could there be more specific detail about what automated accessibility checks are performed?

@jlhdxw jlhdxw enabled auto-merge February 13, 2025 14:15
@jlhdxw jlhdxw merged commit 743e77e into main Feb 13, 2025
3 checks passed
@jlhdxw jlhdxw deleted the FCL-631/add-font-end-adrs branch February 13, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants