HERITAGE-429 updating of footer links urls #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TNA-Allan
requested changes
Nov 1, 2024
templates/includes/footer.html
Outdated
| @@ -11,22 +11,22 @@ | |||
| <nav class="tna-footer__legal tna-column tna-column--full" aria-label="General site links"> | |||
| <ul class="tna-footer__legal-items tna-ul tna-ul--plain"> | |||
| <li class="tna-footer__legal-item"> | |||
| <a href="https://www.nationalarchives.gov.uk/help/web-accessibility/" class="tna-footer__legal-item-link"> | |||
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.accessibility-statement" class="tna-footer__legal-item-link"> | |||
There was a problem hiding this comment.
Suggested change
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.accessibility-statement" class="tna-footer__legal-item-link"> | |
| <a href="/using-our-website/#h2.accessibility-statement" class="tna-footer__legal-item-link"> |
Would a relative link be better?
There was a problem hiding this comment.
I agree. Is there an easy way to get the base url via python? Something like {% sitebase %}
There was a problem hiding this comment.
It would get resolved on its own.
see example vis_view_img="/static/images/ohos-homepage-maps.jpg"
There was a problem hiding this comment.
hmmn, well http://127.0.0.1:8000/using-our-website/#h2.accessibility-statement for example gives me a 404.
There was a problem hiding this comment.
The using-our-website page is tied to a login.
There was a problem hiding this comment.
The login can removed via Wagtail Admin as required.
templates/includes/footer.html
Outdated
| Accessibility statement | ||
| </a> | ||
| </li> | ||
| <li class="tna-footer__legal-item"> | ||
| <a href="https://www.nationalarchives.gov.uk/legal/" class="tna-footer__legal-item-link"> | ||
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.terms-and-conditions" class="tna-footer__legal-item-link"> |
There was a problem hiding this comment.
Suggested change
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.terms-and-conditions" class="tna-footer__legal-item-link"> | |
| <a href="/using-our-website/#h2.terms-and-conditions" class="tna-footer__legal-item-link"> |
templates/includes/footer.html
Outdated
| Terms and conditions | ||
| </a> | ||
| </li> | ||
| <li class="tna-footer__legal-item"> | ||
| <a href="https://www.nationalarchives.gov.uk/legal/privacy.htm" class="tna-footer__legal-item-link"> | ||
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.privacy-policy" class="tna-footer__legal-item-link"> |
There was a problem hiding this comment.
Suggested change
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.privacy-policy" class="tna-footer__legal-item-link"> | |
| <a href="/using-our-website/#h2.privacy-policy" class="tna-footer__legal-item-link"> |
templates/includes/footer.html
Outdated
| Privacy policy | ||
| </a> | ||
| </li> | ||
| <li class="tna-footer__legal-item"> | ||
| <a href="https://www.nationalarchives.gov.uk/legal/cookies/" class="tna-footer__legal-item-link"> | ||
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.cookies" class="tna-footer__legal-item-link"> |
There was a problem hiding this comment.
Suggested change
| <a href="https://ohos-zgoyvpy-rasrzs7pi6sd4.uk-1.platformsh.site/using-our-website/#h2.cookies" class="tna-footer__legal-item-link"> | |
| <a href="/using-our-website/#h2.cookies" class="tna-footer__legal-item-link"> |
TNA-Allan
requested changes
Nov 4, 2024
There was a problem hiding this comment.
@JohnHeeryTNA ,
I am getting an error
TemplateDoesNotExist at /using-our-website/
includes/card-group-secondary-nav.html
templates/includes/card-group-secondary-nav.html is missing.
You could get it from ds-wagtail repo I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket URL: https://national-archives.atlassian.net/jira/software/c/projects/HERITAGE/issues/HERITAGE-429
About these changes
URls from footer links have been updated
How to check these changes
Run locally, confirm links function correctly
Before assigning to reviewer, please make sure you have
Merging PR guidance
Follow docs\developer-guide\contributing.md
Deployment guidance
Follow docs\infra\environments.md