(WIP) Migrate render html #9
Conversation
| translateY: 'block', | ||
| borderCurve: 'block', | ||
| gap: 'block', | ||
| inset: 'block', | ||
| insetBlock: 'block', | ||
| insetInline: 'block', | ||
| marginBlock: 'block', | ||
| marginInline: 'block', | ||
| paddingBlock: 'block', | ||
| paddingInline: 'block', | ||
| objectFit: 'block' |
There was a problem hiding this comment.
@DorianMazur That won't work; this is due to the new react-native version supporting more of these props. But we need to implement the rules for each of these.
I suggest you instead:
- suppress the error by adding
as neverafter the object literal; - open a ticket to report the issue, I'll work on it;
- add a comment referring to the ticket number, showing this is a momentarily hack.
| ? renderFn(assembledProps) | ||
| ? renderFn(assembledProps as any) |
There was a problem hiding this comment.
@DorianMazur We prefer as never to as any (well we prefer none). This is immediate technical debt, please open a ticket and add a reference to this ticket in a comment to this line.
| "paths": { | ||
| "@native-html/transient-render-engine": [ | ||
| "./packages/transient-render-engine/src" | ||
| ], | ||
| "@native-html/css-processor": ["./packages/css-processor/src"] | ||
| } |
There was a problem hiding this comment.
@DorianMazur Can we scope this out of the PR? You should be fine as soon as you build each dependency manually. Since it is not a blocker, I suggest we address this in a separate PR; and discuss it as a single topic.
There was a problem hiding this comment.
Sure, I will remove it today.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@jsamr Do we want to keep the Nevermind, I see now that yarn considers that as an endorsed approach |
|
@jsamr Maybe should all fixes and version upgrades in packages other than Again, nevermind, I see that this PR contains general dependencies upgrade |
No description provided.