Override always default Android hostname verifier #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following problem:
A couple of months ago, Android stopped accepting self-signed certificates without SAN value when performing a WS call. I took a look at nativescript-https's code and there's this option
validatesDomainName
: iffalse
, it uses default Android hostname verification which throws the mentioned error; iftrue
, it uses a custom hostname verifier.With my proposed change, the custom verifier will always be used, but it will return
true
ifvalidatesDomainName === false
and will use current logic ifvalidatesDomainName === true
. This can be returned some lines before, just at the beginning ofverify
and save some processing, but I think it looks fancier this way. I'll modify the code if needed.I used this for a development environment and I thought it was useful since I saw some people having the same problem. I think this could be useful for someone else.
Best regards from
_travelDevs
.