Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add repro for rendering issue #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test: add repro for rendering issue #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions demo_vue/app/components/ListItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
<template functional>
<GridLayout rows="60, auto, 40">
<Label row="0"
textAlignment="center"
:text="props.item.type + ' ' + props.index"/>

<!-- Content -->
<ContentView row="1">
<slot>
<Label textWrap :text="props.item.body" row="1" class="content"/>
</slot>
</ContentView>

<GridLayout columns="*, *" row="2">
<Button @tap="() => listeners.toggleLike()"
:text="props.item.liked ? ' Unlike' : ' Like'"
:color="props.item.liked ? 'blue' : 'black'"
col="0" row="1"/>
<Button text="Blah"
col="1" row="1"/>
</GridLayout>
</GridLayout>
</template>

<script>
export default {
functional: true,
props: {
item: {
type: Object,
required: true
},
index: Number
}
}
</script>
229 changes: 229 additions & 0 deletions demo_vue/app/components/Repro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,229 @@
<template>
<Page>
<CollectionView for="item in listItems"
separatorColor="transparent">

<!-- A post with a single image -->
<v-template if="item.type === 'post.image.single'">
<ListItem :item="item" :index="$index" @toggleLike="togglePostLike(item)">
<GridLayout rows="auto, auto">
<Label textWrap :text="item.body" class="content"/>

<Label backgroundColor="red"
height="200"
stretch="aspectFill"
row="1"/>
</GridLayout>
</ListItem>
</v-template>

<!-- A post with 2 images -->
<v-template if="item.type === 'post.image.double'">
<ListItem :item="item" :index="$index" @toggleLike="togglePostLike(item)">
<GridLayout rows="auto, auto" columns="*, *">
<Label textWrap :text="item.body" class="content" colSpan="2"/>

<Label backgroundColor="red"
height="200"
stretch="aspectFill"
col="0"
row="1"/>
<Label backgroundColor="green"
height="200"
stretch="aspectFill"
col="1"
row="1"/>
</GridLayout>
</ListItem>
</v-template>

<!-- A post with more than 2 images -->
<v-template if="item.type === 'post.image.multiple'">
<ListItem :item="item" :index="$index" @toggleLike="togglePostLike(item)">
<GridLayout rows="auto, auto, auto" columns="2*, *">
<Label textWrap :text="item.body" class="content" colSpan="2"/>

<Label backgroundColor="red"
height="200"
stretch="aspectFill"
col="0"
row="1"
rowSpan="2"/>
<Label backgroundColor="green"
height="100"
stretch="aspectFill"
col="1"
row="1"/>
<Label backgroundColor="blue"
height="100"
stretch="aspectFill"
col="1"
row="2"/>
</GridLayout>
</ListItem>
</v-template>

<!-- A default post if there are no events or images -->
<v-template if="item.type === 'post'">
<ListItem :item="item" :index="$index" @toggleLike="togglePostLike(item)"/>
</v-template>

<v-template>
<Label color="blue" :text="`Missing template: ${item.type} - ${$index}`"/>
</v-template>

<!--<v-template if="item.type === 'post'">-->
<!-- &lt;!&ndash;<Label :text="JSON.stringify(item, null, 2)"/>&ndash;&gt;-->
<!-- <GridLayout rows="50, *, 50" margin="8" background="white" ___height="800px">-->
<!-- &lt;!&ndash; Top Actions &ndash;&gt;-->
<!-- <Label backgroundColor="rgba(255, 0, 0, 0.2)"/>-->

<!-- &lt;!&ndash; Content &ndash;&gt;-->
<!-- <Label :text="item.body" textWrap row="1"/>-->
<!-- &lt;!&ndash;<Label text="Static text to test" textWrap row="1"/>&ndash;&gt;-->

<!-- &lt;!&ndash; Bottom Actions &ndash;&gt;-->
<!-- <Label @tap="togglePostLike(item, $index)"-->
<!-- :text="item.liked ? 'Unlike' : 'Like'"-->
<!-- backgroundColor="rgba(0, 0, 255, 0.2)"-->
<!-- row="2"/>-->
<!-- </GridLayout>-->
<!--</v-template>-->

<v-template if="item.type === 'indicator' && item.state === 'loading'">
<GridLayout rows="auto" padding="24">
<Label text="Loading..." row="1"/>
</GridLayout>
</v-template>
<v-template if="item.type === 'indicator' && item.state === 'end'">
<GridLayout rows="auto" padding="24">
<Label text="Reached end." row="1"/>
</GridLayout>
</v-template>
</CollectionView>
</Page>
</template>

<script>
import ListItem from './ListItem'
import {ObservableArray} from '@nativescript/core'
import {loremIpsum} from 'lorem-ipsum'

const getType = (images, event) => {
let type = 'post'

if (event && images === 0) {
type = 'post.event'
} else if (images === 1) {
type = 'post.image.single'
} else if (images === 2) {
type = 'post.image.double'
} else if (images > 2) {
type = 'post.image.multiple'
}
return type
}
const genPost = (sentences, images = 0, event = false) => ({
liked: false,
type: getType(images, event),
body: loremIpsum({
count: sentences,
format: 'html'
})
})
const loadItems = () => new Promise(resolve => setTimeout(() => {
resolve({
items: [
genPost(1, 0, true),
genPost(3, 1, false),
genPost(1, 2, false),
genPost(10, 5, false),
genPost(1, 0, false),
genPost(1, 4, false),
genPost(1, 1, true),
genPost(1, 0, true),
genPost(10, 3, false),
genPost(1, 2, false),
genPost(10, 1, false),
genPost(1, 1, false),
genPost(10, 0, false),
]
})
}, 1000))

const ListStates = {
IDLE: 'idle',
LOADING: 'loading',
END: 'end'
}

export default {
data() {
return {
feedItems: [],
listState: ListStates.IDLE,
listItemsObservable: new ObservableArray([])
}
},
watch: {
listItems: {
handler(items) {
console.log('listItems changed')
this.listItemsObservable.splice(0)
this.listItemsObservable.push(items)
},
deep: true
}
},
computed: {
listItems() {
const items = this.feedItems
//
// if (this.listState !== ListStates.IDLE) {
// items.push({
// type: 'indicator',
// state: this.listState
// })
// }
console.log('listItems computed changed')

return items
}
},
created() {
this.fetchItems()
},
methods: {
async fetchItems() {
if (this.listState !== ListStates.IDLE) {
return
}

this.listState = ListStates.LOADING
const res = await loadItems().catch(err => {
console.log(err)
})

if (!res.items || res.items.length === 0) {
this.listState = ListStates.END
return
}

this.feedItems = res.items
this.listState = ListStates.IDLE

},

async togglePostLike(item) {
console.log('post like changed')
item.liked = !item.liked
// this.listItemsObservable.setItem(this.listItemsObservable.indexOf(item), {
// ...item,
// })
}
},
components: {
ListItem
}
}
</script>
2 changes: 1 addition & 1 deletion demo_vue/app/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Vue from 'nativescript-vue';
import App from './components/App.vue';
import App from './components/Repro.vue';

import { Label as HTMLLabel } from 'nativescript-htmllabel'; // require first to get Font res loading override
// Vue.registerElement('Label', () => HTMLLabel);
Expand Down
1 change: 1 addition & 0 deletions demo_vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"dependencies": {
"@mdi/font": "4.9.95",
"@nativescript/core": "^6.5.1",
"lorem-ipsum": "^2.0.3",
"nativescript-collectionview": "../plugin",
"nativescript-gesturehandler": "^0.1.8",
"nativescript-htmllabel": "^1.0.32",
Expand Down