Add ClusterTraffic to account claims
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10801003787Details
💛 - Coveralls |
aricart
reviewed
Aug 1, 2024
For supporting nats-io/nats-server#5466. For now expected values would be: * `"system"` - use the system account (default, as today) * `"owner"` - use the same account that owns the asset * `"account:ACCNAME"` - use a third specified `ACCNAME` Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/accountnrg
branch
from
270cc45
to
bc9fb5f
Compare
neilalexander
changed the title
NRGAccount to account claimsClusterTraffic to account claims
|
CI failure seems to be related to installing |
Signed-off-by: Neil Twigg <[email protected]>
neilalexander
force-pushed
the
neil/accountnrg
branch
from
e7c1d7f
to
2e1251e
Compare
Signed-off-by: Neil Twigg <[email protected]>
aricart
approved these changes
Sep 10, 2024
derekcollison
added a commit
to nats-io/nats-server
that referenced
this pull request
Sep 13, 2024
…5466) This PR adds the ability to move NRG traffic out of the system account and into the asset accounts. Particularly in heavily multi-tenanted systems, this can help cases where head-of-line blocking may happen in the system account due to large amounts of replication traffic. This needs to be enabled on a per-account basis on each participating server. Servers advertise their capability to support account NRG to each other. If a Raft group detects a peer coming up without support, they will revert back to using the system account automatically. Requires nats-io/jwt#223 and then `go.mod` updating. Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For supporting nats-io/nats-server#5466.
For now expected values would be:
"system"- use the system account (default, as today)"owner"- use the same account that owns the asset"account:ACCNAME"- use a third specifiedACCNAMESigned-off-by: Neil Twigg [email protected]