Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation to cluster traffic - as downstream tools like nsc will need to perform some level of validation #224

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Added validation to cluster traffic - as downstream tools like nsc will need to perform some level of validation #224

merged 2 commits into from
Sep 13, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 11, 2024

No description provided.

@coveralls
Copy link

coveralls commented Sep 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10851743667

Details

  • 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 81.111%
Changes Missing Coverage Covered Lines Changed/Added Lines %
v2/account_claims.go 7 9 77.78%
Totals Coverage Status
Change from base Build 10801439726: -0.009%
Covered Lines: 2744
Relevant Lines: 3383
💛 - Coveralls

wallyqs
wallyqs approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neilalexander
neilalexander approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart mentioned this pull request Sep 13, 2024
Merged
@aricart aricart merged commit 2d9ece2 into main Sep 13, 2024
6 of 8 checks passed
@aricart aricart deleted the cluster-traffic branch September 13, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aricart @coveralls @wallyqs @neilalexander