Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] require consumer/stream names to not contain spaces, newlines, carriage returns or tabs #585

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Sep 6, 2023

Fixes #584

…ed characters on names

- relaxed a validation on `name` which only allowed [A-Za-z0-9_]
- linter warnings
…ed characters on names

- relaxed a validation on `name` which only allowed [A-Za-z0-9_]
- linter warnings
@aricart aricart requested a review from Jarema September 6, 2023 11:47
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart
Copy link
Member Author

aricart commented Sep 6, 2023

For KV, keys and buckets have actually even more restrictions:

const validKeyRe = /^[-/=.\w]+$/;

for OS, bucket names are validated:

export function objectStoreStreamName(bucket: string): string {

Keys etc are base64 encoded so it doesn't matter what is provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clamp validation on stream/consumer names and kv/object store
2 participants