[ADDED] Force reconnect #1624
Merged
[ADDED] Force reconnect #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
force-pushed
the
force-reconnect
branch
from
3242548
to
29dd974
Compare
|
@piotrpio |
Signed-off-by: Piotr Piotrowski <[email protected]>
Signed-off-by: Piotr Piotrowski <[email protected]>
wallyqs
reviewed
May 16, 2024
| func TestForceReconnect(t *testing.T) { | ||
| s := RunDefaultServer() | ||
|
|
||
| nc, err := nats.Connect(s.ClientURL(), nats.ReconnectWait(10*time.Second)) |
There was a problem hiding this comment.
Only one behavior that wanted to confirm is whether we get an error on disconnect or not, and it seems the disconnect callback is called but without an error which I think it is good, e.g.
nats.DisconnectErrHandler(func(_ *nats.Conn, err error) {
t.Logf("ERROR: %v", err) // error is nil here
}),There was a problem hiding this comment.
Yes, the callback is invoked without error which I thought is a reasonable behavior.
Merged
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <[email protected]>
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses nats-io/nats-architecture-and-design#259
Signed-off-by: Piotr Piotrowski [email protected]