Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : removed the unnecessary usage of ErrInvalidMsg #1811

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix : removed the unnecessary usage of ErrInvalidMsg #1811

wants to merge 2 commits into from
+2 −2

Conversation

Radovenchyk
Copy link

No description provided.

piotrpio
piotrpio requested changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@piotrpio piotrpio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Radovenchyk, thanks for creating the PR. I'm not sure I understand this change, what's wrong with ErrInvalidMsg when the message is invalid (nil)? Also, there is no such error as ErrInvalid so this does not compile.

@Radovenchyk
Copy link
Author

I jumped to conclusions, it really doesn't compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotrpio piotrpio piotrpio requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Radovenchyk @piotrpio