Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flytable_base4table too conservative listing tables #197

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

jefferis
Copy link
Collaborator

  • It can spend 45s listing tables 4x out of a 60s seatable cell types query ...
  • this may still be overkill (rescanning if a table can't be found) but probably safest compromise

* It can spend 45s listing tables 4x out of a 60s seatable cell types query ...
* this may still be overkill (rescanning if a table can't be found) but probably safest compromise
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6d88e89) 54.38% compared to head (dbea404) 54.37%.

Files Patch % Lines
R/flytable.R 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   54.38%   54.37%   -0.02%     
==========================================
  Files          38       38              
  Lines        4773     4776       +3     
==========================================
+ Hits         2596     2597       +1     
- Misses       2177     2179       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefferis jefferis merged commit 30c2dbe into master Feb 17, 2024
3 of 5 checks passed
@jefferis jefferis deleted the feature/flytable-cell-types-speedup branch February 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant