Direct support for flyem shorturls including via tinyurl #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* picked up by new checks
* we might want this to use cached fetches for e.g. google storage
* even works when you have a tinyurl URL encoding a json short URL
* return.json did not give correct values in all circumstances * document that flywire_expandurl now returns a long url not error * also update test of this behaviour
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
==========================================
+ Coverage 56.70% 56.84% +0.13%
==========================================
Files 38 38
Lines 4807 4827 +20
==========================================
+ Hits 2726 2744 +18
- Misses 2081 2083 +2 ☔ View full report in Codecov by Sentry. |
* add extra tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.