Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark DirectSoundOut as Windows only #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ds5678
Copy link

@ds5678 ds5678 commented Sep 10, 2022

DirectSoundOut uses COM Interop and native method calls to dsound.dll and user32.dll. This pull request marks the class as Windows-only to make it more clear to users that this will not function on other platforms.

This pull request also adds a nontransitive reference to PolySharp, which is required to use the SupportedOSPlatform attribute on .NET Standard.

@ds5678 ds5678 force-pushed the direct-sound-out-windows-only-net6 branch from f31e390 to 17079c0 Compare September 4, 2023 01:28
@ds5678 ds5678 changed the title Mark DirectSoundOut as Windows only and add a .NET 6 target Mark DirectSoundOut as Windows only Sep 4, 2023
@ds5678 ds5678 force-pushed the direct-sound-out-windows-only-net6 branch from 17079c0 to 5e2ae4a Compare September 4, 2023 01:32
@ds5678
Copy link
Author

ds5678 commented Sep 4, 2023

I rebased and updated my pull request to be more inline with my current coding standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant