-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLEANUP: use bkey instead of subkey when it only related to btree #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฆฌ๋ทฐ ์๋ฃ
@@ -448,12 +448,12 @@ CollectionPipedUpdateOperation collectionPipedUpdate(String key, | |||
* Increment/Decrement operation for collection items (b+tree items). | |||
* | |||
* @param key b+tree item's key | |||
* @param subkey element key | |||
* @param bkey b+tree item's bkey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"b+tree element's key"๋ก ํํํ๋ ๊ฒ์ด ์ข๊ฒ ์ต๋๋ค.
@@ -271,10 +271,10 @@ public BTreeGetBulkOperation bopGetBulk(BTreeGetBulk<?> getBulk, | |||
|
|||
@Override | |||
public CollectionMutateOperation collectionMutate(String key, | |||
String subkey, | |||
String bkey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฉ์๋ ๋ช ์ด๋ ๋ฆฌํด ํ์ ๋ฑ์ ๋ด์๋ b+tree ํ์ ๋ ์ฐ์ฐ์ด ์๋๋ฏ๋ก subkey ์ฉ์ด๋ฅผ ๊ทธ๋๋ก ๋์ด์ผ ํ์ง ์๋ ์ง?
์๋ง b+tree์์๋ง ์ฌ์ฉํ๋ค๊ณ ๋ณ๊ฒฝํ ๊ฒ์ผ๋ก ๋ณด์ด๋ ๋ฐ,
ํฅํ ๋ค๋ฅธ collection(์, map)์์๋ ์ด ์ฐ์ฐ์ ์ ๊ณต๋ ์ ์์ ๊ฒ ๊ฐ์ต๋๋ค.
์ด๋ป๊ฒ ํ๋ ๊ฒ์ด ์ข์๊น์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํฅํ ์ ๊ณต๋ ๊ฐ๋ฅ์ฑ์ด ๋๋ค๋ฉด ๊ทธ๋๋ก ๋๊ฒ ์ต๋๋ค.
๋ค๋ง, ๋ณธ PR์์ ์์ ํ์ง ์๋๋ค ํ๋๋ผ๋ subkey๋ผ๋ ๋ง์ง ์๋ ์ฉ์ด๋ฅผ ๊ทธ๋๋ก ์ฐ๊ณ ์๋ ๊ฒ ์์ฒด๊ฐ ๋ฌธ์ ๋ผ์ ์ถํ ๋ค๋ฅธ๋ฐฉ์์ ์๊ฐํด์ผ ํ ๊ฒ ๊ฐ์ต๋๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด ๋ถ๋ถ์ ํ์ฌ PR์ฒ๋ผ bkey๋ก ๋ณ๊ฒฝํ๋ ๊ฑธ๋ก ํฉ์๋ค.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ด์ฐจํผ ๋์ค์ collectionInsert, collectionUpdate ๋ฑ์์ subkey ์ฉ์ด๋ฅผ ๋ณ๊ฒฝํ ๋ ํ๊บผ๋ฒ์ ์ฒ๋ฆฌํ๋ฉด ๋ ๊ฒ ๊ฐ์, ์ด PR์์๋ ๋ณ๊ฒฝ ์ํ๋ ค๊ณ ํฉ๋๋ค. ๊ด์ฐฎ์ผ์ ๊ฐ์?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์. ๊ทธ๋ ๊ฒ ํ์์ฃ .
@jhpark816 ์์ ํ์ต๋๋ค. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฆฌ๋ทฐ ์๋ฃ
@@ -59,14 +59,14 @@ public class CollectionMutateOperationImpl extends OperationImpl implements | |||
false, "OUT_OF_RANGE", CollectionResponse.OUT_OF_RANGE); | |||
|
|||
protected final String key; | |||
protected final String subkey; | |||
protected final String bkey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฌ๊ธฐ๋ CollectionMutateOperation ์ ๋๋ค.
@jhpark816 ๋ฐ์ํ์ต๋๋ค. |
๐ Related Issue
โจ๏ธ What I did