Skip to content

Commit

Permalink
Removed default TagLib version from Dockerfile. Now it always require…
Browse files Browse the repository at this point in the history
… the version and sha to build
  • Loading branch information
deluan committed Oct 16, 2024
1 parent ad2c55a commit 435437d
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,16 @@ FROM scratch AS xx
COPY --from=xx-build /out/ /usr/bin/

FROM --platform=$BUILDPLATFORM public.ecr.aws/docker/library/debian:bookworm-20240926-slim AS base
ARG TAGLIB_VERSION=2.0.2
ARG TAGLIB_SHA=e3de03501ff66221d1f1f971022b248d5b38ba06

# Install platform agnostic build dependencies
RUN apt-get update && apt-get install -y clang lld cmake git
COPY --from=xx / /

# TagLib version and SHA. This should be passed as build args and usually comes from the .version file
ARG TAGLIB_VERSION
ARG TAGLIB_SHA
RUN test -n "$TAGLIB_VERSION" || (echo "TAGLIB_VERSION and TAGLIB_SHA args are required. Try using `make build`" && exit 1)

# Download TagLib source for specified version
RUN cd / && \
git clone https://github.com/taglib/taglib.git taglib-src && \
Expand Down

0 comments on commit 435437d

Please sign in to comment.