prioriter navn og kjønn som kommer fra PDL og ikke Freg #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FredrikP <[email protected]>
Signed-off-by: FredrikP <[email protected]>
Signed-off-by: FredrikP <[email protected]>
Signed-off-by: FredrikP <[email protected]>
stigebil
reviewed
Feb 11, 2025
src/main/kotlin/no/nav/familie/ba/sak/integrasjoner/pdl/domene/PdlHentPersonResponse.kt
Outdated
Show resolved
Hide resolved
stigebil
reviewed
Feb 11, 2025
| fun List<PdlNavn>.filtrerNavnPåKilde(): PdlNavn? = | ||
| this | ||
| .filter { it.metadata.historisk == false } | ||
| .minByOrNull { PdlMaster.valueOf(it.metadata.master.uppercase()).prioritet } |
There was a problem hiding this comment.
Vil fungere dårlig hvis det er andre kilder enn PDL og FREG
There was a problem hiding this comment.
Lagt inn en when-sjekk i stedet for enum nå :)
stigebil
reviewed
Feb 11, 2025
Signed-off-by: FredrikP <[email protected]>
Signed-off-by: FredrikP <[email protected]>
|
stigebil
approved these changes
Feb 11, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Hva skal gjøres, og hvorfor?
Favro
Ref pdl-doc så ønsker vi å bruke PDL som master og ikke Freg når vi får verdier fra begge.
Velger derfor å ta med metadata, master og historisk for å kunne filtrere ut når det er flere kilder til navn/kjønn.
Dokumentasjon om metadata og kilder
✅ Checklist
Har du husket alle punktene i listen?