-
Notifications
You must be signed in to change notification settings - Fork 5
Fiks noen ts expect errors #6691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
| VurdereAnnenYtelseForVedtakAp | ||
| UttakAp | ||
| BeregningAksjonspunktSubmitType | ||
| Partial<BeregningAksjonspunktSubmitType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usikker om dette er beste løsning. Er litt rart å inkludere en submitType her som ikke har samme optionals som andre?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja den er litt pussig denne typen, men dette er vel neppe beste måte å løysa på. Kanskje greit med ts-ignore inntil vidare?
saksnummer: string; | ||
bekreftedeAksjonspunktDtoer: ({ | ||
'@type': string; | ||
'@type': string | undefined; // TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bør ha kommentar
saksnummer: string; | ||
overstyrteAksjonspunktDtoer: ({ | ||
'@type': string; | ||
'@type': string | undefined; // TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kommentar
riktigYtelseBeløp: number; | ||
}; | ||
|
||
type VedtakResultatType = 'INGEN_TILBAKEBETALING' | 'DELVIS_TILBAKEBETALING'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
denne kan byttast ut med VedtakResultatType i fp-types
export const usePanelDataContext = <AP_TYPE extends AksjonspunktType>() => { | ||
// @ts-expect-error Johannes ser på denne - mismatch mellom type i ft-repo og generert type | ||
const context = useContext<Props<AP_TYPE> | null>(PanelDataContext); | ||
const context = useContext(PanelDataContext); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dette er vel det same som ligg på master
| VurdereAnnenYtelseForVedtakAp | ||
| UttakAp | ||
| BeregningAksjonspunktSubmitType | ||
| Partial<BeregningAksjonspunktSubmitType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ja den er litt pussig denne typen, men dette er vel neppe beste måte å løysa på. Kanskje greit med ts-ignore inntil vidare?
No description provided.