Skip to content

Conversation

tor-nav
Copy link
Collaborator

@tor-nav tor-nav commented Oct 3, 2025

No description provided.

@tor-nav tor-nav requested a review from a team as a code owner October 3, 2025 10:06
@tor-nav tor-nav requested a review from johannbm October 3, 2025 10:20
[AndreKriterierType.TIL_BESLUTTER]: true,
[`${AndreKriterierType.TIL_BESLUTTER}_inkluder`]: true,
['TIL_BESLUTTER' satisfies AndreKriterierType]: true,
[`${'TIL_BESLUTTER' satisfies AndreKriterierType}_inkluder`]: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jøss, spenstig syntax

cancelEvent={skjulModal}
frist={behandling.fristBehandlingPåVent}
ventearsak={behandling.venteÅrsakKode}
ventearsak={behandling.venteÅrsakKode as VenteArsakType}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bedre med en ts-expect-error enn "as" ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja einig, har fiksa

ventearsaker: KodeverkMedNavn<'Venteårsak'>[] | KodeverkMedNavnTilbakekreving<'Venteårsak'>[];
frist?: string | null;
ventearsak?: string | null;
ventearsak?: VenteArsakType | null;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ikke relatert til det du har gjort. Men er vel sjeldent vi egentlig trenger at noe er både null | undefined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ja eg gidda berre ikkje retta opp... men har gjort det no

'FOR_TIDLIG_SOKNAD',
'VENT_OPDT_INNTEKTSMELDING',
'VENT_UTLAND_TRYGD',
'UTV_TIL_FRIST',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tror det er tilbakekreving. UTV_TIL_FRIST finnes der

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dei to etter denne manglar og, sikkert i tilbake dei og

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, den IKKE_SEND greia virker hacky

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jepp, eg har ein ts-expect-error der i tilknytning dette

let arbeidsforholdMedPositivSaldoFinnes = false;

const konto = stonadskonto.stonadskontoer[periodeTypeKode as StonadskontoType];
const konto = stonadskonto.stonadskontoer[periodeTypeKode as StønadskontoType];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endrer du heller funksjonssignaturen

periodeTypeKode: foreldrepenger_behandlingslager_behandling_ytelsefordeling_periode_UttakPeriodeType,

så ser det ut til at du slipper "as"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn it!

Copy link

sonarqubecloud bot commented Oct 3, 2025

@tor-nav tor-nav merged commit e505073 into master Oct 6, 2025
7 checks passed
@tor-nav tor-nav deleted the kodeverk-til-types-v3 branch October 6, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants