-
Notifications
You must be signed in to change notification settings - Fork 5
Flytt kodeverk til fp-types - del 3 #6695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[AndreKriterierType.TIL_BESLUTTER]: true, | ||
[`${AndreKriterierType.TIL_BESLUTTER}_inkluder`]: true, | ||
['TIL_BESLUTTER' satisfies AndreKriterierType]: true, | ||
[`${'TIL_BESLUTTER' satisfies AndreKriterierType}_inkluder`]: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jøss, spenstig syntax
cancelEvent={skjulModal} | ||
frist={behandling.fristBehandlingPåVent} | ||
ventearsak={behandling.venteÅrsakKode} | ||
ventearsak={behandling.venteÅrsakKode as VenteArsakType} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bedre med en ts-expect-error enn "as" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ja einig, har fiksa
ventearsaker: KodeverkMedNavn<'Venteårsak'>[] | KodeverkMedNavnTilbakekreving<'Venteårsak'>[]; | ||
frist?: string | null; | ||
ventearsak?: string | null; | ||
ventearsak?: VenteArsakType | null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ikke relatert til det du har gjort. Men er vel sjeldent vi egentlig trenger at noe er både null | undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ja eg gidda berre ikkje retta opp... men har gjort det no
'FOR_TIDLIG_SOKNAD', | ||
'VENT_OPDT_INNTEKTSMELDING', | ||
'VENT_UTLAND_TRYGD', | ||
'UTV_TIL_FRIST', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tror det er tilbakekreving. UTV_TIL_FRIST finnes der
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dei to etter denne manglar og, sikkert i tilbake dei og
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh, den IKKE_SEND greia virker hacky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jepp, eg har ein ts-expect-error der i tilknytning dette
let arbeidsforholdMedPositivSaldoFinnes = false; | ||
|
||
const konto = stonadskonto.stonadskontoer[periodeTypeKode as StonadskontoType]; | ||
const konto = stonadskonto.stonadskontoer[periodeTypeKode as StønadskontoType]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
endrer du heller funksjonssignaturen
periodeTypeKode: foreldrepenger_behandlingslager_behandling_ytelsefordeling_periode_UttakPeriodeType,
så ser det ut til at du slipper "as"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn it!
|
No description provided.