Skip to content

Commit

Permalink
revert: RST_STREAM(cancel) fix for gRPC, this seems to be breaking JS…
Browse files Browse the repository at this point in the history
… gRPC client (deephaven#6420)

This reverts commit 6ada0cb.

See deephaven#6401 
See deephaven#6400 
See deephaven#5996
  • Loading branch information
niloc132 authored and nbauernfeind committed Dec 5, 2024
1 parent 9c3db73 commit 2ab1088
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,9 @@ public boolean isFinestEnabled() {
transportState.runOnTransportThread(
() -> {
transportState.complete();
// asyncContext.complete();
asyncContext.complete();
log.fine("call completed");
});
// Jetty specific fix: When AsyncContext.complete() is called, Jetty sends a RST_STREAM with
// "cancel" error to the client, while other containers send "no error" in this case. Calling
// close() instead on the output stream still sends the RST_STREAM, but with "no error". Note
// that this does the opposite in at least Tomcat, so we're not going to upstream this change.
// See https://github.com/deephaven/deephaven-core/issues/6400
outputStream.close();
};
this.isReady = () -> outputStream.isReady();
}
Expand Down

0 comments on commit 2ab1088

Please sign in to comment.