Feature/Fix: Dockerfile - Make roughly 43% smaller #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-maldridge
force-pushed
the
even-smaller
branch
from
471b2f1 to
c9eb5a9
Compare
the-maldridge
changed the title
|
Updated the title to consider this a Feature and Fix. Its a feature because the final artifact is considerably smaller now, and a fix because the images had a bunch of stuff that they didn't need in them, mostly the very broken remnants of APK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a combination of
upxand a choosier copy I was able to reduce the final image size to 4.7M from the top of main. I have not yet tested this on a routeros target as I haven't got containers enabled in my test environment yet, but I believe the changes should be safe.