Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace utility methods with ActiveSupport #15

Open
wants to merge 67 commits into
base: master
Choose a base branch
from
Open

Replace utility methods with ActiveSupport #15

wants to merge 67 commits into from

Commits on May 13, 2018

  1. Explicitly specify ruby version

    @amilligan
    amilligan committed May 13, 2018
    Configuration menu
    Copy the full SHA
    d6319d6 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Include rubocop for style analysis

    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    00407c6 View commit details
    Browse the repository at this point in the history

  2. Place dot operator consistently on multiline calls 

    rubocop: Layout/DotPosition
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    0682175 View commit details
    Browse the repository at this point in the history

  3. Remove extraneous whitespace 

    rubocop:
- Layout/EmptyLines
- Layout/EmptyLinesAroundAccessModifier
- Layout/EmptyLinesAroundBlockBody
- Layout/EmptyLinesAroundClassBody
- Layout/EmptyLinesAroundMethodBody
- Layout/EmptyLinesAroundModuleBody
- Layout/ExtraSpacing
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    cd1055b View commit details
    Browse the repository at this point in the history

  4. Indent consistently 

    rubocop:
- Layout/IndentationConsistency
- Layout/IndentationWidth
- Layout/MultilineMethodCallIndentation
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    919f9fc View commit details
    Browse the repository at this point in the history

  5. Space parameters and operator consistently 

    rubocop:
- Layout/SpaceAfterComma
- Layout/SpaceAroundEqualsInParameterDefault
- Layout/SpaceAroundOperators
- Layout/SpaceInsideBlockBraces
- Layout/SpaceInsideHashLiteralBraces
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    b293021 View commit details
    Browse the repository at this point in the history

  6. Include trailing line consistently in all files 

    rubocop: Layout/TrailingBlankLines
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    93d2ddd View commit details
    Browse the repository at this point in the history

  7. Fix ambiguous regexp literal 

    rubocop: Lint/AmbiguousRegexpLiteral
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    348e28c View commit details
    Browse the repository at this point in the history

  8. Clarify assignment in conditional expressions 

    rubocop: Lint/AssignmentInConditions
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ad197e1 View commit details
    Browse the repository at this point in the history

  9. Remove duplicate accessor method definition 

    rubocop: Lint/DuplicateMethods
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    e502a76 View commit details
    Browse the repository at this point in the history

  10. Make private methods actually private 

    rubocop: Lint/IneffectiveAccessModifier
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    cd48ba8 View commit details
    Browse the repository at this point in the history

  11. Replace obsolete method call 

    rubocop: Lint/UriEscapeUnescape
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    97cb0f8 View commit details
    Browse the repository at this point in the history

  12. Remove useless variable assignments 

    rubocop: Lint/UselessAssignment
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    95feef9 View commit details
    Browse the repository at this point in the history

  13. Replace unnecessary hash merge 

    rubocop: Performance/RedundantMerge
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    41d9e5b View commit details
    Browse the repository at this point in the history

  14. Prefer boolean operator in condition 

    rubocop: Style/AndOr
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    32f770f View commit details
    Browse the repository at this point in the history

  15. Enforce consistent brace/paren/etc. style 

    rubocop:
- Style/BracesAroundHashParameters
- Style/EmptyLiteral
- Style/EmptyMethod
- Style/MethodDefParentheses
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    efc5b1f View commit details
    Browse the repository at this point in the history

  16. Use interpolated strings only when required 

    rubocop: Style/StringLiterals
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    718b1eb View commit details
    Browse the repository at this point in the history

  17. Remove unnecessary string interpolation 

    rubocop: Style/UnneededInterpolation
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    43f892e View commit details
    Browse the repository at this point in the history

  18. Remove redundant uses of self 

    rubocop: Style/RedundantSelf
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    69ee0a9 View commit details
    Browse the repository at this point in the history

  19. Prefer parameterized method of raising exceptions 

    rubocop: Style/RaiseArgs
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    37a817e View commit details
    Browse the repository at this point in the history

  20. Use next to skip iteration 

    rubocop: Style/Next
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    cbcf708 View commit details
    Browse the repository at this point in the history

  21. Avoid unnecessarily negated conditions 

    rubocop: Style/NegatedIf
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    b8a1243 View commit details
    Browse the repository at this point in the history

  22. Freeze mutable objects set as constants 

    rubocop: Style/MutableConstant
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    aba084a View commit details
    Browse the repository at this point in the history

  23. Replace inverted use of select with reject 

    rubocop: Style/InverseMethods
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f6237f0 View commit details
    Browse the repository at this point in the history

  24. Use modifier conditional syntax when applicable 

    rubocop: Style/IfUnlessModifier
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    da65008 View commit details
    Browse the repository at this point in the history

  25. Add guard clause to method 

    rubocop: Style/GuardClause
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    7e822a2 View commit details
    Browse the repository at this point in the history

  26. Simplify file path expansion 

    rubocop: Style/ExpandPathArguments
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    382d668 View commit details
    Browse the repository at this point in the history

  27. Make rubocop accept the main gem filename

    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    2b64f88 View commit details
    Browse the repository at this point in the history

  28. Remove redunant variable assignment 

    rubocop: Style/ConditionalAssignment
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    873cd93 View commit details
    Browse the repository at this point in the history

  29. Consistently use #is_a? for class check 

    rubocop: Style/ClassCheck
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ac57423 View commit details
    Browse the repository at this point in the history

  30. Remove rubocop requirement for JavaDoc-style docs

    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    7b8dc0e View commit details
    Browse the repository at this point in the history

  31. Consistently use ruby-style variable names 

    rubocop: Naming/VariableName
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    9564afe View commit details
    Browse the repository at this point in the history

  32. Use descriptive method parameter names 

    rubocop: Naming/UncommunicativeMethodParamName
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    d8c5fac View commit details
    Browse the repository at this point in the history

  33. Rename method to avoid ambiguity with accessor 

    rubocop: Naming/AccessorMethodName
    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    4814ab9 View commit details
    Browse the repository at this point in the history

  34. Creating TODO file for remaining rubocop issues

    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    2b693e8 View commit details
    Browse the repository at this point in the history

  35. Add rake task for rubocop, and include in default

    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    a079b93 View commit details
    Browse the repository at this point in the history

  36. Specify old-ish ruby (2.2) for rubocop

    @amilligan
    amilligan committed May 14, 2018
    Configuration menu
    Copy the full SHA
    f71e199 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. Remove redundant gem dependency

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    24d32ab View commit details
    Browse the repository at this point in the history

  2. Add missing gem dependency

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    fd5fe47 View commit details
    Browse the repository at this point in the history

  3. Add rspec with default configuration

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    92610d2 View commit details
    Browse the repository at this point in the history

  4. Add rake task for specs, and add to default

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    f69610d View commit details
    Browse the repository at this point in the history

  5. Require project files in specs

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    ac52777 View commit details
    Browse the repository at this point in the history

  6. Add webmock gem for network testing

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d5e3e89 View commit details
    Browse the repository at this point in the history

  7. Use URI.join to build URLs 

    Rather than string interpolation or concatenation.
    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    f387096 View commit details
    Browse the repository at this point in the history

  8. Add basic test for HTTP requests

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    42f2960 View commit details
    Browse the repository at this point in the history

  9. Extract common HTTP request test behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    0641421 View commit details
    Browse the repository at this point in the history

  10. Simplify Organization creation methods

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    f1ca55d View commit details
    Browse the repository at this point in the history

  11. Add basic specs for Organization attributes

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    b604315 View commit details
    Browse the repository at this point in the history

  12. Specialize shared examples for different requests

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    560498b View commit details
    Browse the repository at this point in the history

  13. Add specs for API list behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    86b0023 View commit details
    Browse the repository at this point in the history

  14. Add specs for API create behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    00ba2e1 View commit details
    Browse the repository at this point in the history

  15. Add specs for API delete behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    8971fa7 View commit details
    Browse the repository at this point in the history

  16. Add specs for API update behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    3d0ca01 View commit details
    Browse the repository at this point in the history

  17. Add specs for API query by metadata behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    9079ae0 View commit details
    Browse the repository at this point in the history

  18. Add specs for API save behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    2c120d6 View commit details
    Browse the repository at this point in the history

  19. Add rspec helper dependency

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d464079 View commit details
    Browse the repository at this point in the history

  20. Add specs for Destination object

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    90aedd7 View commit details
    Browse the repository at this point in the history

  21. Properly camelize request keys in expectations

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    597a067 View commit details
    Browse the repository at this point in the history

  22. Add specs for Recipient object

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    08ec9dd View commit details
    Browse the repository at this point in the history

  23. Add specs for API find behavior

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    d897ac1 View commit details
    Browse the repository at this point in the history

  24. Add specs for Task object

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    eb3cfd7 View commit details
    Browse the repository at this point in the history

  25. Add specs for Team object

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    726407a View commit details
    Browse the repository at this point in the history

  26. Add specs for Webhook object

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    f37610c View commit details
    Browse the repository at this point in the history

  27. Add specs for Worker object

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    cb77a2e View commit details
    Browse the repository at this point in the history

  28. Remove unnecessary utility method

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    0f10434 View commit details
    Browse the repository at this point in the history

  29. Replace utility methods with existing methods

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    2cbfd93 View commit details
    Browse the repository at this point in the history

  30. Move global function to class where it is used

    @amilligan
    amilligan committed May 15, 2018
    Configuration menu
    Copy the full SHA
    80cad85 View commit details
    Browse the repository at this point in the history