Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure API object attributes #16

Open
wants to merge 78 commits into
base: master
Choose a base branch
from
Open

Restructure API object attributes #16

wants to merge 78 commits into from

Conversation

amilligan
Copy link
Contributor

This series of changes encapsulates the processing of parameters, and the generation of JSON for requests, into the individual API objects. It also adds to the Onfleet object DSL to define how object parameters should be processed and converted to JSON.

These changes fix issues #11 and #12.

@amilligan
Explicitly specify ruby version
d6319d6
@amilligan
Include rubocop for style analysis
00407c6
@amilligan
Place dot operator consistently on multiline calls
0682175 
rubocop: Layout/DotPosition
@amilligan
Remove extraneous whitespace
cd1055b 
rubocop:
- Layout/EmptyLines
- Layout/EmptyLinesAroundAccessModifier
- Layout/EmptyLinesAroundBlockBody
- Layout/EmptyLinesAroundClassBody
- Layout/EmptyLinesAroundMethodBody
- Layout/EmptyLinesAroundModuleBody
- Layout/ExtraSpacing
@amilligan
Indent consistently
919f9fc 
rubocop:
- Layout/IndentationConsistency
- Layout/IndentationWidth
- Layout/MultilineMethodCallIndentation
@amilligan
Space parameters and operator consistently
b293021 
rubocop:
- Layout/SpaceAfterComma
- Layout/SpaceAroundEqualsInParameterDefault
- Layout/SpaceAroundOperators
- Layout/SpaceInsideBlockBraces
- Layout/SpaceInsideHashLiteralBraces
@amilligan
Include trailing line consistently in all files
93d2ddd 
rubocop: Layout/TrailingBlankLines
@amilligan
Fix ambiguous regexp literal
348e28c 
rubocop: Lint/AmbiguousRegexpLiteral
@amilligan
Clarify assignment in conditional expressions
ad197e1 
rubocop: Lint/AssignmentInConditions
@amilligan
Remove duplicate accessor method definition
e502a76 
rubocop: Lint/DuplicateMethods
@amilligan
Make private methods actually private
cd48ba8 
rubocop: Lint/IneffectiveAccessModifier
@amilligan
Replace obsolete method call
97cb0f8 
rubocop: Lint/UriEscapeUnescape
@amilligan
Remove useless variable assignments
95feef9 
rubocop: Lint/UselessAssignment
@amilligan
Replace unnecessary hash merge
41d9e5b 
rubocop: Performance/RedundantMerge
@amilligan
Prefer boolean operator in condition
32f770f 
rubocop: Style/AndOr
@amilligan
Enforce consistent brace/paren/etc. style
efc5b1f 
rubocop:
- Style/BracesAroundHashParameters
- Style/EmptyLiteral
- Style/EmptyMethod
- Style/MethodDefParentheses
@amilligan
Use interpolated strings only when required
718b1eb 
rubocop: Style/StringLiterals
@amilligan
Remove unnecessary string interpolation
43f892e 
rubocop: Style/UnneededInterpolation
@amilligan
Remove redundant uses of self
69ee0a9 
rubocop: Style/RedundantSelf
@amilligan
Prefer parameterized method of raising exceptions
37a817e 
rubocop: Style/RaiseArgs
@amilligan
Use next to skip iteration
cbcf708 
rubocop: Style/Next
@amilligan
Avoid unnecessarily negated conditions
b8a1243 
rubocop: Style/NegatedIf
@amilligan
Freeze mutable objects set as constants
aba084a 
rubocop: Style/MutableConstant
@amilligan
Replace inverted use of select with reject
f6237f0 
rubocop: Style/InverseMethods
@amilligan
Use modifier conditional syntax when applicable
da65008 
rubocop: Style/IfUnlessModifier
@amilligan
Add guard clause to method
7e822a2 
rubocop: Style/GuardClause
@amilligan
Simplify file path expansion
382d668 
rubocop: Style/ExpandPathArguments
@amilligan
Make rubocop accept the main gem filename
2b64f88
@amilligan
Remove redunant variable assignment
873cd93 
rubocop: Style/ConditionalAssignment
@amilligan
Consistently use #is_a? for class check
ac57423 
rubocop: Style/ClassCheck
@amilligan
Specialize shared examples for different requests
560498b
@amilligan
Add specs for API list behavior
86b0023
@amilligan
Add specs for API create behavior
00ba2e1
@amilligan
Add specs for API delete behavior
8971fa7
@amilligan
Add specs for API update behavior
3d0ca01
@amilligan
Add specs for API query by metadata behavior
9079ae0
@amilligan
Add specs for API save behavior
2c120d6
@amilligan
Add rspec helper dependency
d464079
@amilligan
Add specs for Destination object
90aedd7
@amilligan
Properly camelize request keys in expectations
597a067
@amilligan
Add specs for Recipient object
08ec9dd
@amilligan
Add specs for API find behavior
d897ac1
@amilligan
Add specs for Task object
eb3cfd7
@amilligan
Add specs for Team object
726407a
@amilligan
Add specs for Webhook object
f37610c
@amilligan
Add specs for Worker object
cb77a2e
@amilligan
Remove unnecessary utility method
0f10434
@amilligan
Replace utility methods with existing methods
2cbfd93
@amilligan
Move global function to class where it is used
80cad85
@amilligan
Add specs for Onfleet object initialization
a768033
@amilligan
Add DSL for Onfleet API objects
771642d
@amilligan
Rename attributes method for clarity
62ce07c
@amilligan
Replace dynamic instance variables with collection
0d4d569
@amilligan
Add DSL methods for specifying object associations
5cfde55
@amilligan
Add Hub Onfleet object
0abf767
@amilligan
Specify associated API objects with DSL
ba694e4
@amilligan
Encapsulate JSON-ification in API objects
924d1d7
@amilligan
Restore spec examples that are now deterministic
6d636d5
@amilligan
Camelize barcode attribute keys properly
dc75abe
@amilligan
Update rubocop TODO
7582659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amilligan