#138 Add cwd template variable #300
Open
+47
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandreh2ag
force-pushed
the
add_cwd_variable
branch
from
3dc5828
to
c1ee74d
Compare
|
Hello @ncabatoff, Thanks |
ncabatoff
reviewed
Jul 21, 2024
proc/read.go
Outdated
| if p.cwd == "" { | ||
| cwd, err := p.Cwd() | ||
|
|
||
| if err != nil && strings.Contains(err.Error(), "permission denied") { |
There was a problem hiding this comment.
Any reason you can't use errors.Is(err, fs.ErrPermission)?
There was a problem hiding this comment.
Hello @ncabatoff,
You are right, I modified the code.
alexandreh2ag
force-pushed
the
add_cwd_variable
branch
from
c1ee74d
to
bb354cb
Compare
Signed-off-by: alexandreh2ag <[email protected]>
alexandreh2ag
force-pushed
the
add_cwd_variable
branch
from
bb354cb
to
dd45a99
Compare
|
hello |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
As discussed here #138, i purpose this PR to add CWD template variable.
Please let me know if i need to add any changes.