update pom checker

ncats · Feb 1, 2024 · 4fc5769 · 4fc5769
1 parent 0b19647
commit 4fc5769
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/...odule-substances-tests/src/test/java/gsrs/substances/tests/SubstancesPomsVersionTest.java b/...odule-substances-tests/src/test/java/gsrs/substances/tests/SubstancesPomsVersionTest.java
@@ -23,8 +23,8 @@ public class SubstancesPomsVersionTest {
     // Set to true when testing in IDE
     boolean turnOffPomParameterCheck = false;
 
-    String shortVersion;
-    String longVersion;
+    String starterModuleVersion;
+    String substancesModuleVersion;
     String rootDir;
     String propertiesFile;
     String installExtraJarsScriptText;
@@ -40,11 +40,10 @@ public void setup() {
 
         try {
             Properties properties = PomUtilities.readPomVersionProperties(rootDir + "/" + propertiesFile);
-            shortVersion = properties.getProperty("project.shortVersion");
-            longVersion = properties.getProperty("project.longVersion");
-            assertNotNull(shortVersion);
-            System.out.println("shortVersion: " + shortVersion);
-            System.out.println("longVersion: " + longVersion);
+            starterModuleVersion = properties.getProperty("gsrs.substances.pomversiontest.starterModuleVersion");
+            substancesModuleVersion = properties.getProperty("gsrs.substances.pomversiontest.substancesModuleVersion");
+            assertNotNull(starterModuleVersion);
+            assertNotNull(substancesModuleVersion);
         } catch (IOException e) {
             throw new RuntimeException(e);
         }
@@ -66,16 +65,18 @@ public void testPomCheck() {
             rootModel = PomUtilities.readPomToModel(rootDir + "/pom.xml");
             Properties properties = rootModel.getProperties();
             System.out.println("> checking root");
-            assertEquals( longVersion, rootModel.getVersion(), "version");
-            assertEquals(longVersion, properties.getProperty("gsrs.version"), "gsrs.version:");
+            assertEquals( substancesModuleVersion, rootModel.getVersion(), "version");
+            assertEquals(starterModuleVersion, properties.getProperty("gsrs.version"), "gsrs.version:");
+            assertEquals(substancesModuleVersion, properties.getProperty("gsrs.substance.version"), "gsrs.substance.version:");
+
             List<String> modules = rootModel.getModules();
             for (String module : modules) {
                 System.out.println("> checking "+ module);
                 Model moduleModel;
                 try {
                     moduleModel = PomUtilities.readPomToModel(rootDir + "/" + module + "/pom.xml");
                     String checkVersion = moduleModel.getParent().getVersion();
-                    assertEquals (longVersion, checkVersion, "parent/version");
+                    assertEquals (substancesModuleVersion, checkVersion, "parent/version");
 
                     if (module.equals("gsrs-fda-substance-extension")) {
                         List<Dependency> dependencies = moduleModel.getDependencies();

diff --git a/pom-version.properties b/pom-version.properties
@@ -1,3 +1,4 @@
 # For use in project pom version check test
-project.shortVersion=3.1
-project.longVersion=3.1
+
+gsrs.substances.pomversiontest.starterModuleVersion=3.1
+gsrs.substances.pomversiontest.substancesModuleVersion=3.1.0.5-SNAPSHOT