-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selenium grid support #45
base: master
Are you sure you want to change the base?
Conversation
I was thinking about about this naming convention and I don't feel comfortable with separate options prefixed with sauce_ or grid_ which are then copied to one desired_capabilities object. I would prefer one desired_capabilities object which is used by sauce labs and selenium grid – common selenium configuration(this will also solve #37 and allow proxy support for selenium grid). I can prepare such change in separate PR, which will be back compatible with current solution. Old parameters will be shown in log as deprecated and can be removed in the future. |
That would be great. Do you need permissions to be a contributor to this repo? That may be easier than forking. Thanks for your input! |
Wait, I'm not sure how this works, as this repo is technically NCBI's. Let me ask. |
Alas, it's a bit of a pain to make you a direct contributer to repos in NCBI. So go ahead and do it in a fork and we will merge. |
@s4int, @frishberg @hellmanj Hi where are we with this? As I remember and from reviewing the comments @s4int was going to rename the options etc. Though you don't have access to this branch directly and we don't have the ability to add you as a contributor to the NCBI project. |
Hi, I'm steel interested. Now I'm preparing PR with renamed variables |
@kahunacohen @s4int any updates on this? We also use an internal Selenium Grid and would like this feature. Thanks. |
The truth is we are most likely putting this project up for adoption. Robot didn't work out so well for our organization. I will make an announcement and edit the reader. You are of course free to fork it. Sent from my iPhone
|
Can you please share more details as to why Robot framework did not work for your organization, and what alternate route you're picking? Thanks in advance.
|
Slow python 3 support in Robot Framework, developers prefer writing tests On Tue, Sep 1, 2015 at 11:23 AM, Zohar Lorberbaum [email protected]
|
Really a shame this didn't get merged in, trying to run it but having trouble (newb here). |
@kahunacohen, we can close this right? Since #42 takes care of it? @conversica-aaronpa, did you ever figure out how to use selenium-grid with this? |
Yes, have been able to work with local selenium grid (docker hosted too, very nice) in place of Sauce Labs via fork: https://github.com/conversica-aaronpa/robotframework-pageobjects |
I actually was thinking #42 took care of it, but I had misread. I'm finally looking over and merging pull requests now, and see if I can resolve conflicts and merge this one. |
@s4int
See also #42.
I made some changes to the order and wording of options. @hellmanj , @frishberg last thing bothering me is two options for browser version, one for sauce and one for grid. I guess the option should be browser_version, not sauce_browserversion. That's an API-breaking change though isn't it? Or should I not be concerned, other than having to make some changes in the source code?