fix test for real - check for grouped scale factors

ncborcherding · Oct 30, 2024 · 73aee34 · 73aee34
1 parent e824414
commit 73aee34
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/tests/testthat/test-clonalCompare.R b/tests/testthat/test-clonalCompare.R
@@ -76,16 +76,26 @@ test_that("clonalCompare works with exportTable and prop FALSE", {
     propCompareRes %>% dplyr::select(-Proportion)
   )
 
-  fullJoined <- getClonalCompareRes(FALSE) %>%
-    dplyr::full_join(
-      getClonalCompareRes(TRUE)
-    )
+  fullJoined <- suppressMessages(getClonalCompareRes(FALSE) %>%
+    dplyr::full_join(getClonalCompareRes(TRUE))
+  )
 
   expect_setequal(
     colnames(fullJoined),
     c("clones", "Count", "original.clones", "Proportion", "Sample")
   )
 
+  expect_identical(
+    fullJoined %>%
+      dplyr::mutate(propToCountScaleFactor = Count / Proportion) %>%
+      dplyr::group_by(Sample) %>%
+      dplyr::summarise(
+        areAllFactorsEqual = var(propToCountScaleFactor) < 1e-10
+      ) %>%
+      dplyr::pull(areAllFactorsEqual),
+    rep(TRUE, length(unique(fullJoined$Sample)))
+  )
+
   countPropFactor <- fullJoined$Count / fullJoined$Proportion
 
   expect_identical(