-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of .lvCompare()
#425
Conversation
@ncborcherding Just realized that the vignette build failed in the R-CMD-check with the following:
and also
Will get on that later. Unsure why vignette is failing since it wasn't really touched. |
Looks like the I think the magick warning is a BiocStyle issue. |
.lvCompare()
}) | ||
cluster <- bind_rows(cluster.list) | ||
cluster <- bind_rows(cluster.list) # the TRA_cluster isnt assigned in the failing test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ncborcherding Could you maybe describe what exactly this intermediate variable is supposed to be? Struggling to debug downstream atm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qile0317 Here the cluster.list
is the cluster assignments from the .lv.compare()
function that are grouped into list elements, bind_rows()
is just forming a data frame from the list.
@ncborcherding actually - I just commented out a failing test - I think this is still broken :P this was my fault for not communicating well - I can do another PR for undoing the merge? |
@Qile0317 Don't worry about it and sorry for not catching it - why don't you make a new PR for the sole issue itself. I think that will save both of use time and be more straightforward. Nick |
A general improvement on the runtime of
combineBCR()
by accelerating.lvCompare()
with rcpp by a small constant factor.