Fix TRUST4 loadContigs issue in #429 #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncborcherding For the example single row data given in #429 the output after fixing all code contains two rows where the first row contains the correct information, but the second row is just all NA's with the exact same barcode as the first row. Is this intended behaviour? It happens since there was no chain1 data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #429
The issue ended up being that matrix subsetting in R reduces matricies to vectors when the subsetted result will only have 1 column/row which caused an error when trying to do
colnames()<-. Fixed this by using drop = FALSE as the k argument in matrix subsetting. This may or may not be present in other functions too - haven't checked yet.Also did some general reformatting and refactoring but no functionality has been affected.