Bringing terminology up to 5.3+ spec (Master/Slave -> Central/Peripheral) #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that Sniffle was written around spec 5.2 before the Central/Peripheral terminology was introduced, but in our BLE class we use spec 5.4 and mostly teach students Central/Peripheral terminology. Since we'll be using Sniffle a lot, it'd be good if it was using the same terminology. So I did a find and replace on terms and then reverted things back that caused compilation errors. I confirmed the firmware compiles and installs to a Sonoff and Sniffing continues to work.
p.s. I don't see a way to squash the commits into a single commit. I think you might need to configure that on Github settings? (https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests)