Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing terminology up to 5.3+ spec (Master/Slave -> Central/Peripheral) #106

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

XenoKovah
Copy link
Contributor

I know that Sniffle was written around spec 5.2 before the Central/Peripheral terminology was introduced, but in our BLE class we use spec 5.4 and mostly teach students Central/Peripheral terminology. Since we'll be using Sniffle a lot, it'd be good if it was using the same terminology. So I did a find and replace on terms and then reverted things back that caused compilation errors. I confirmed the firmware compiles and installs to a Sonoff and Sniffing continues to work.

p.s. I don't see a way to squash the commits into a single commit. I think you might need to configure that on Github settings? (https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests)

@sultanqasim sultanqasim merged commit 20a9441 into nccgroup:master Jan 10, 2025
@sultanqasim
Copy link
Collaborator

Merging this as it's useful for terminology to remain consistent with the specification. Personally, I don't like the new terminology because I feel it's less descriptive of the actual behaviour in connections and the change was unnecessary politically motivated churn. One peripheral can have multiple centrals connected to it, and the central/peripheral terminology makes less obvious who controls connection parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants