Fix incorrect header serialization in streamed responses #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an incorrect header serialization in streamed responses (when `@streaming` is true); the return value from `HttpStreamingResponse.headers` consists of arrays of strings rather than plain strings, which in turn causes Rack to fail. Since `Rack::Proxy` already has a helper to normalize this, this change ensures it always gets called.
|
@ncr can this get merged? |
|
I’ll release a new gem tomorrow. If not, ping me please :) |
|
Awesome, thanks! Just ran into a problem where I was POSTing to a rack-proxy URL that had streaming enabled, and the browser was downloading the response as a file. Turning streaming off fixed the issue. I'm assuming this PR fixes the problem? |
|
Not sure to be honest, can you check it? I don't use rack-proxy these days,
just merging PRs :)
pon., 26 mar 2018 o 22:12 użytkownik Joe Van Dyk <[email protected]>
napisał:
… Awesome, thanks! Just ran into a problem where I was POSTing to a
rack-proxy URL that had streaming enabled, and the browser was downloading
the response as a file. Turning streaming off fixed the issue. I'm assuming
this PR fixes the problem?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAWpKdt_rhdMdra9bdWQDqnTvTLpVx0ks5tiUuYgaJpZM4SnGDa>
.
|
|
@ncr did you ever release the new gem version? I'm not seeing it on rubygems. |
|
Just released. Sorry for the delay :)
pt., 14 wrz 2018 o 16:10 użytkownik Martin Posthumus <
[email protected]> napisał:
… @ncr <https://github.com/ncr> did you ever release the new gem version?
I'm not seeing it on rubygems.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#73 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAWpPJAemKEye88OByiNTb0o066uS4Mks5ua7jOgaJpZM4SnGDa>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect header serialization in streamed responses (when
@streamingis true); the return value fromHttpStreamingResponse.headersconsists of arrays of strings ratherthan plain strings, which in turn causes Rack to fail.
Since
Rack::Proxyalready has a helper to normalize this, this changeensures it always gets called.
This resolves issue #65 .