Develop #129
Merged
Develop #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror out when running
…e, which is what broke the sequencing error modeling task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found a line that was removed in a previous edit that should not have been. Restored that line (which tabulates scores by position, in order to come up with per-position predictions), and discovered a previous fix in the last commit was actually obscuring the bug and should have been an error instead, so we updated that. We also added a quick way to scan the document and count the number of lines that seems to work very quickly, though it will need to be monitored to ensure it doesn't cause an unwanted slowdown on larger files.