Fix for Large icon on sessions export page #579 #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haietza
force-pushed
the
iconfix
branch
2 times, most recently
from
883cead
to
9d219ac
Compare
|
Thanks @haietza! This change makes sense to me. It seems that on Moodle 4.3, an SVG is being used instead of the previous image, so not specifying the width and height caused it to be full width. Don't worry about the CI failures - we're resolving them in a separate PR. |
|
To get this moving again, @jrchamp will:
That will allow the other PRs to rebase and move forward. |
jrchamp
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
@smbader investigated to see if there was a pre-existing class that should be used instead. There did not seem to be any instances that were using the icon in a context like this, so using a new, specific CSS selector makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add css class and style for Excel icon for export of participants to resolve #579