Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: migrate from label to badge (Bootstrap 3 -> 4/5) #608

Merged
merged 2 commits into from
Aug 8, 2024

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    cb1c944 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. index: use dark badge styles

    Even with the backward/forward compatibility, bg-info text-dark was not sufficient contrast for WCAG 2.x AA. Forcing text-dark also had the drawback of not working well in "dark mode" themes. So if we can't use text-dark, then Bootstrap 5.0 and 5.1 will need to use the default text color. That leaves "primary", "secondary", "success", "danger" and "dark". primary and secondary are already used for buttons to Join or Cancel. success did not have sufficient contrast in all versions that we tested. danger is specifically designed to scare/alert people, so that seemed wrong. dark is the only option that has sufficient contrast, isn't designed to scare people, and does not conflict with the mental model of action buttons.
    jrchamp authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4a7c222 View commit details
    Browse the repository at this point in the history