Implement registration validation (Version 2) #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check to see if current user is capable of creating meetings with the registration option
Set 'use_pmi' to false when registration is requested.
paulandm
changed the title
jrchamp
reviewed
Oct 17, 2024
classes/webservice.php
Outdated
| */ | ||
| public function get_user_registration_capable() { | ||
| global $USER; | ||
| $zoomuser = $this->get_user($USER->email); |
There was a problem hiding this comment.
We lookup users based on the configured field, so there's a different code pattern for getting the person. Also, there is a function that caches the results, so we can avoid unnecessary API calls.
Suggested change
| $zoomuser = $this->get_user($USER->email); | |
| $zoomuser = zoom_get_user(zoom_get_api_identifier($USER)); |
mod_form.php
Outdated
| // Check licensing of the user. | ||
| $registrationcapableuserfound = zoom_webservice()->get_user_registration_capable(); | ||
| if (!$registrationcapableuserfound) { | ||
| $errors['registration'] = get_string('err_registration', 'zoom'); |
There was a problem hiding this comment.
We use the full frankenstyle name, not the activity module shortname.
Suggested change
| $errors['registration'] = get_string('err_registration', 'zoom'); | |
| $errors['registration'] = get_string('err_registration', 'mod_zoom'); |
mod_form.php
Outdated
Comment on lines
1179
to
1180
| $registrationcapableuserfound = zoom_webservice()->get_user_registration_capable(); | ||
| if (!$registrationcapableuserfound) { |
There was a problem hiding this comment.
I feel weird about the use of the English word "capable", because it implies "fitness". Translation to other languages may also be negatively affected. "allowed" or "permitted" seem more appropriate to me, because they imply "licensed", "granted", "has the permission".
Implemented PR feedback/suggestions.
|
Hi @jrchamp Thanks for your feedback. I've implemented the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to see if current user is capable of creating meetings with the registration option enabled.
It seems like only users with a 'Pro' license are capable of creating such meetings.