Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Improve description of DVC use #5

Merged
merged 4 commits into from
Jan 24, 2024
Merged

README.md: Improve description of DVC use #5

merged 4 commits into from
Jan 24, 2024

Conversation

jnareb
Copy link
Member

@jnareb jnareb commented Jan 24, 2024

Jakub Narębski (4):
README.md: Mention Git repo requirement in "Running with DVC"
README.md: Add "Description of DVC stages" subsection
README.md: Improve the look of dvc dag diagram
README.md: Add "Additional stages' requirements" subsection

This addresses the following complaint:

> In addition, while I was able to set up the environment easily
> thanks to the `init.bash` script provided, the script did not work
> completely. It failed first because the README.md is not mentioning
> that the script needs to be run inside a git project directory.
This addresses the following complaint:

> The README.md is missing a description of the activities carried
> out by each stage and a general overview of the pipeline
> (You could've presented the DVC dag and a brief description
> of each stage, for instance).
By reordering lines in the source of the simplified graph of DVC stage
dependencies (in Mermaid format: https://mermaid.js.org/), there is
less edge crossing, and the `dvc dag` diagram looks better.
This section describes such DVC pipeline stage requirements like
Internet access, or having `git` installed, or a valid GitHub API key.
@jnareb jnareb merged commit 940411e into main Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant