Skip to content

Add support for SHA-256 and SHA-512 digests in temporary URLs #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexandrePhilibert
Copy link

This PR refers to #189.

I introduced two new functions ObjectTempUrlSha256 and ObjectTempUrlSha512. The encoding of the sha512 signature is not the same as the others which results in some duplicated code.

I noticed that the TestTempUrl test isn't failing in my swift environment when the signature is wrong. If I intentionally change the signature, my Swift server returns a 401, which the test considers as the server not supporting temporary URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant