-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to postgresql #477
base: master
Are you sure you want to change the base?
Conversation
@opeolluwa yeah I think having to ship config files is not ideal if you want to have a single binary. I think the way to go would be to just use env vars instead of any config file, not even use yaml. |
Awesome, I know we'd have a port, JWT signing key and database connection. Would that be all or there's more |
@opeolluwa Regarding the Docker image, I’m not completely sure. Initially, I wanted the project to include lots of features, but now days I’m leaning towards keeping it as simple as possible, is easier to mantain. If we do decide to include Docker, I think we should use the official Rust image tho. |
Hmmm |
Here is what we use: https://github.com/ndelvalle/rustapi/blob/master/src/settings.rs. |
The primary reason for docker is because of the database, actually |
@ndelvalle would you mind docker or I should just use set up PostgreSQL locally |
@ndelvalle I'm trying to dockerize this to make it easier to setup and run but the code panics,
Can we possibly revamp the application config using
yaml
like i did here https://github.com/opeolluwa/backend-in-rust/blob/master/02_auth_jwt/src/config.rs or best we use environment variables