Implement single expression QA checks #715

dodumosu · 2020-05-20T08:23:18Z

This pull request adds some enhancements to QA expressions in order to fully resolve nditech/apollo-issues#39

takinbo

We should have test cases for this change.

takinbo · 2020-05-24T20:58:32Z

migrations/versions/1e17be41a449_migrate_qa_expressions.py

+def upgrade():
+    # ### commands auto generated by Alembic - please adjust! ###
+    fetch_query = sa.sql.text(
+        "SELECT id, quality_checks FROM form WHERE quality_checks IS NULL OR quality_checks = 'null'::jsonb;")  # noqa


Can you review this SQL query? Shouldn't it be IS NOT NULL?

takinbo · 2020-05-24T21:01:59Z

migrations/versions/1e17be41a449_migrate_qa_expressions.py

+    for form_id, quality_checks in op.execute(fetch_query).fetchall():
+        for quality_check in quality_checks:
+            if 'expression' not in quality_check:
+                quality_check['expression'] = qb.build_expression(


Since we are practically doing away with criteria for quality_check shouldn't we also clean up the code and not have portions of the code that will never be used going forward? That should be the purpose of the data migration.

takinbo · 2020-05-24T21:02:39Z

apollo/templates/admin/quality_assurance.html

@@ -39,9 +39,13 @@
              <td class="text-monospace align-middle"><a href="{{ url_for('formsview.quality_control_edit', form_id=form.id, qa=control.name) }}" class="text-decoration-none">{{ control.name }}</a></td>
              <td class="text-monospace align-middle">{{ control.description }}</td>
              <td class="text-monospace align-middle">
+              {%- if 'expression' in control -%}
+                <h5><span class="badge badge-pill badge-primary">{{ control.expression }}</span></h5>
+              {%- else -%}
              {%- for criterion in control.criteria %}


We would not be needing criteria anymore so the code should be cleaned up some.

takinbo · 2020-05-24T21:03:24Z

apollo/submissions/qa/query_builder.py

-    if 'criteria' in logical_check:
+    if 'expression' in logical_check:
+        control_expression = logical_check.get('expression')
+    elif 'criteria' in logical_check:


No need for criteria

the migration working depends on this staying unchanged.

What if this was just put in the migration itself?

i'm also using it in the form import, which i have since updated

takinbo · 2020-05-24T21:05:21Z

apollo/formsframework/views_forms.py

-            if 'criteria' in quality_check:
+            if 'expression' in quality_check:
+                quality_control['expression'] = quality_check['expression']
+            elif 'criteria' in quality_check:


Remove check for criteria

takinbo · 2020-05-24T21:06:48Z

apollo/submissions/qa/query_builder.py

@@ -27,8 +29,10 @@
 name = r'[a-zA-Z_][a-zA-Z0-9_]*'
 lookup = "$" ("location" / "participant" / "submission") ("." / "@") name
 null = "NULL"
+true = "TRUE"


I don't think we have comparisons for TRUE or FALSE, it was put there as a hack when we were using the three-part criterion for the quality assurance and so isn't needed.

this commit fixes an issue with the QA dashboard, where checklists that should be marked as "missing" are marked as "flagged"

single-expression type

this commit adds a data migration for QA checks to single expressions

- this commit fixes an issue with the migration script where the user receives an `AttributeError` while running it - it also doesn't assume that QA is present on the form

dodumosu · 2023-12-19T16:48:04Z

At this point, a rewrite would be better than a rebase.

dodumosu · 2023-12-19T16:56:05Z

reopening to note, but still needs a lot of work

dodumosu requested a review from takinbo May 20, 2020 08:23

dodumosu force-pushed the complex-qa-logic branch from 738363c to a406db2 Compare May 21, 2020 02:56

takinbo requested changes May 24, 2020

View reviewed changes

dodumosu force-pushed the complex-qa-logic branch from 80439ad to 28a6a53 Compare May 25, 2020 16:57

dodumosu force-pushed the complex-qa-logic branch 2 times, most recently from 2cea70a to 2997c7d Compare June 18, 2020 23:29

dodumosu force-pushed the complex-qa-logic branch from 2997c7d to 9145ce5 Compare June 23, 2020 00:43

dodumosu force-pushed the complex-qa-logic branch 2 times, most recently from 0965183 to ae27e08 Compare July 27, 2020 12:37

dodumosu force-pushed the complex-qa-logic branch 3 times, most recently from 4ea9414 to 876be3c Compare September 24, 2020 08:47

dodumosu force-pushed the complex-qa-logic branch from 876be3c to c5d5b60 Compare October 1, 2020 05:18

dodumosu force-pushed the complex-qa-logic branch from c5d5b60 to 5488150 Compare November 11, 2020 01:25

dodumosu force-pushed the complex-qa-logic branch 2 times, most recently from bc1e20b to f490f61 Compare December 7, 2020 06:29

dodumosu force-pushed the complex-qa-logic branch from f490f61 to 07dfbd8 Compare December 20, 2020 07:05

dodumosu force-pushed the complex-qa-logic branch 3 times, most recently from 4b6c9de to 4649e16 Compare January 9, 2021 22:21

dodumosu force-pushed the complex-qa-logic branch from 4649e16 to 1dca009 Compare January 13, 2021 23:25

dodumosu force-pushed the complex-qa-logic branch 2 times, most recently from b077c58 to c7e81ba Compare February 9, 2021 18:50

dodumosu force-pushed the complex-qa-logic branch from c7e81ba to 6d3cedb Compare April 7, 2021 07:46

dodumosu force-pushed the complex-qa-logic branch from 6d3cedb to 9211c65 Compare April 20, 2021 10:41

dodumosu force-pushed the complex-qa-logic branch from 9211c65 to 17dda8c Compare May 11, 2021 13:57

dodumosu force-pushed the complex-qa-logic branch 2 times, most recently from 64794a6 to 0fb54e7 Compare June 6, 2021 05:22

dodumosu force-pushed the complex-qa-logic branch from 0fb54e7 to 35c99bd Compare June 10, 2021 04:21

dodumosu force-pushed the complex-qa-logic branch from 35c99bd to 1ecc841 Compare June 19, 2021 12:31

dodumosu force-pushed the complex-qa-logic branch 3 times, most recently from 5911047 to 0a6315f Compare August 20, 2021 17:51

dodumosu force-pushed the complex-qa-logic branch from 0a6315f to 00b274b Compare September 6, 2021 09:53

dodumosu added 21 commits September 6, 2021 22:15

feat: add TRUE and FALSE constants to QA grammar

17843f2

feat: add support for single-line QA expressions

2c31bc0

feat: error out for QA on multivalue questions

380f654

fix: add missing import

355cb8a

fix: fix broken "missing" QA logic

a01429d

this commit fixes an issue with the QA dashboard, where checklists that should be marked as "missing" are marked as "flagged"

fix: broken logic in QA dashboard

b15f4cd

feat: add typing to QA processing

5d3b2e8

fix: revert lookups to numeric type

584f4ee

feat: add rendering of QA for

fb34c76

single-expression type

feat: add data migration for QA checks

f7a4462

this commit adds a data migration for QA checks to single expressions

fix: fix broken query in migration

67e9f18

chore: make PEP8 compliant

07b2513

chore: clean up QA template

287b50c

chore: clean up QA view

d444574

feat: update form exports for single QA

bb8732e

feat: update form export to single expression QA

87af461

fix: update form import/export

596ab4d

chore: remove migrated QA criteria

b7670de

chore: remove Boolean constants

da3b385

fix: update migration script

3db2fcc

- this commit fixes an issue with the migration script where the user receives an `AttributeError` while running it - it also doesn't assume that QA is present on the form

chore: reorder migrations

34fd3e3

dodumosu force-pushed the complex-qa-logic branch from 00b274b to 34fd3e3 Compare September 6, 2021 21:15

dodumosu closed this Dec 19, 2023

dodumosu reopened this Dec 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement single expression QA checks #715

Implement single expression QA checks #715

dodumosu commented May 20, 2020

takinbo left a comment

takinbo May 24, 2020

takinbo May 24, 2020

takinbo May 24, 2020

takinbo May 24, 2020

dodumosu May 25, 2020

takinbo May 25, 2020

dodumosu May 25, 2020

takinbo May 24, 2020

takinbo May 24, 2020

dodumosu commented Dec 19, 2023

dodumosu commented Dec 19, 2023

Implement single expression QA checks #715

Are you sure you want to change the base?

Implement single expression QA checks #715

Conversation

dodumosu commented May 20, 2020

takinbo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dodumosu commented Dec 19, 2023

dodumosu commented Dec 19, 2023