Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing / enhancing oauth integration #336

Merged
merged 8 commits into from
Mar 12, 2021
Merged

Testing / enhancing oauth integration #336

merged 8 commits into from
Mar 12, 2021

Conversation

bodom0015
Copy link
Member

@bodom0015 bodom0015 commented Feb 6, 2021

Problem

SSO is fragile and/or not working. We would like to harden this a bit and add some level of support for logging in with CILogon.

Fixes #254

Approach

  • Support oauth2 proxy + Keycloak + CILogon configuration
  • Add a new endpoint that will validate the _oauth2_proxy cookie / session data and use it to ensure that an account is created for the user in Workbench, then issue a JWT for the user
  • Add logic in the dashboard UI module that will send the _oauth2_proxy cookie to the new endpoint mentioned above if the user reaches a protected part of the dashboard without a valid JWT

Other minor changes include:

  • Speed improvements for apiserver and gui Docker image builds
  • Upgrade ng-base Docker image from xenial -> focal (Ubuntu 20.04 LTS) and carbon -> erbium(NodeJS 12 LTS)
  • Cut down on the ambient apiserver container log spam
  • Wait for etcd to finish its own container startup before continuing apiserver startup

How to Test

See nds-org/workbench-helm-chart#24 for test steps

@bodom0015 bodom0015 changed the title [WIP] Testing / enhancing oauth integration Testing / enhancing oauth integration Feb 15, 2021
@bodom0015 bodom0015 changed the base branch from develop to cddr March 12, 2021 20:57
@bodom0015 bodom0015 merged commit a007ac1 into cddr Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm github oauth support
1 participant