[#2] Implement type wrappers for numeric types

ndsev · Sep 12, 2024 · 2aee517 · 2aee517
1 parent a50e9ad
commit 2aee517
Show file tree

Hide file tree

Showing 9 changed files with 1,684 additions and 4 deletions.
diff --git a/.github/workflows/build_windows.yml b/.github/workflows/build_windows.yml
@@ -16,8 +16,12 @@ jobs:
         - { os: "windows-2022", msvc-toolset: "v142", cxx-standard: "17", build-type: "Release" }
         - { os: "windows-2022", msvc-toolset: "v142", cxx-standard: "17", build-type: "Debug" }
 
-        - { os: "windows-2022", mingw-version: "9.4.0", cxx-standard: "17", build-type: "Release" }
-        - { os: "windows-2022", mingw-version: "9.4.0", cxx-standard: "17", build-type: "Debug" }
+        # fires -Werror=conversion on IntWrapper default template argument
+        #- { os: "windows-2022", mingw-version: "9.4.0", cxx-standard: "17", build-type: "Release" }
+        #- { os: "windows-2022", mingw-version: "9.4.0", cxx-standard: "17", build-type: "Debug" }
+
+        - { os: "windows-2022", mingw-version: "11.2.0", cxx-standard: "17", build-type: "Release" }
+        - { os: "windows-2022", mingw-version: "11.2.0", cxx-standard: "17", build-type: "Debug" }
 
     runs-on: ${{matrix.os}}
     name: "\

diff --git a/runtime/ClangTidySuppressions.txt b/runtime/ClangTidySuppressions.txt
@@ -51,6 +51,9 @@ google-explicit-constructor:src/zserio/Span.h:138
 google-explicit-constructor:src/zserio/Span.h:150
 google-explicit-constructor:src/zserio/Span.h:163
 google-explicit-constructor:src/zserio/Span.h:176
+# This is requirement on type wrappers in Zserio C++17 extension
+google-explicit-constructor:src/zserio/Types.h:33
+google-explicit-constructor:src/zserio/Types.h:37
 
 # False positive, this is a template method.
 modernize-use-equals-default:src/zserio/Span.h:80

diff --git a/runtime/src/CMakeLists.txt b/runtime/src/CMakeLists.txt
@@ -39,6 +39,7 @@ set(ZSERIO_CPP17_RUNTIME_LIB_SRCS
     zserio/FloatUtil.cpp
     zserio/FloatUtil.h
     zserio/HashCodeUtil.h
+    zserio/OutOfRangeException.h
     zserio/RebindAlloc.h
     zserio/RuntimeArch.h
     zserio/SizeConvertUtil.cpp

diff --git a/runtime/src/zserio/BitSizeOfCalculator.cpp b/runtime/src/zserio/BitSizeOfCalculator.cpp
@@ -7,7 +7,7 @@
 namespace zserio
 {
 
-static const std::array<uint64_t, 2> VARIN16_MAX_VALUES = {
+static const std::array<uint64_t, 2> VARINT16_MAX_VALUES = {
         (UINT64_C(1) << (6)) - 1,
         (UINT64_C(1) << (6 + 8)) - 1,
 };
@@ -116,7 +116,7 @@ static uint64_t convertToAbsValue(T value)
 
 size_t bitSizeOfVarInt16(int16_t value)
 {
-    return bitSizeOfVarIntImpl(convertToAbsValue(value), VARIN16_MAX_VALUES, "varint16");
+    return bitSizeOfVarIntImpl(convertToAbsValue(value), VARINT16_MAX_VALUES, "varint16");
 }
 
 size_t bitSizeOfVarInt32(int32_t value)

diff --git a/runtime/src/zserio/OutOfRangeException.h b/runtime/src/zserio/OutOfRangeException.h
@@ -0,0 +1,20 @@
+#ifndef ZSERIO_OUT_OF_RANGE_EXCEPTION_H_INC
+#define ZSERIO_OUT_OF_RANGE_EXCEPTION_H_INC
+
+#include "zserio/CppRuntimeException.h"
+
+namespace zserio
+{
+
+/**
+ * Exception thrown when a value is out of range.
+ */
+class OutOfRangeException : public CppRuntimeException
+{
+public:
+    using CppRuntimeException::CppRuntimeException;
+};
+
+} // namespace zserio
+
+#endif // ifndef ZSERIO_OUT_OF_RANGE_EXCEPTION_H_INC