Extend wallet-account to support signAndSendTransactionAsync, signTransaction, sendTransaction & signDelegateAction #1449
+897
−622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea7b0de The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gagdiez
reviewed
Jan 17, 2025
gagdiez
reviewed
Jan 27, 2025
| const nonce = Number(accessKey.access_key.nonce) + 1; | ||
| const transaction = createTransaction(this.accountId, publicKey, receiverId, nonce, actions, blockHash); | ||
|
|
||
| this.walletConnection.requestSignTransactions({ |
There was a problem hiding this comment.
don't we need to be async as well? otherwise I think you are only making it async if there is a function call key available
gagdiez
reviewed
Jan 27, 2025
| const nonce = Number(accessKey.access_key.nonce) + 1; | ||
| const transaction = createTransaction(this.accountId, publicKey, signedTx.transaction.receiverId, nonce, signedTx.transaction.actions, blockHash); | ||
|
|
||
| this.walletConnection.requestSignTransactions({ |
There was a problem hiding this comment.
if you are sending a transaction to the network, there is no need to request another signature on it
gagdiez
reviewed
Jan 27, 2025
| const blockHash = baseDecode(block.header.hash); | ||
| const publicKey = PublicKey.from(accessKey.public_key); | ||
| const nonce = Number(accessKey.access_key.nonce) + 1; | ||
| const transaction = createTransaction(this.accountId, publicKey, receiverId, nonce, actions, blockHash); |
There was a problem hiding this comment.
don't you need to create a Delegate Transaction?
gagdiez
reviewed
Jan 27, 2025
| const nonce = Number(accessKey.access_key.nonce) + 1; | ||
| const transaction = createTransaction(this.accountId, publicKey, receiverId, nonce, actions, blockHash); | ||
|
|
||
| this.walletConnection.requestSignTransactions({ |
There was a problem hiding this comment.
is this command valid for signing delegate transactions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
Test Plan
Related issues/PRs